config

tylerbutler · tylerbutler · commit 52d1c4d0c051 · 2025-12-03T15:59:22.000-08:00
diff --git a/common/build/eslint-config-fluid/base.js b/common/build/eslint-config-fluid/base.js
@@ -135,6 +135,20 @@ module.exports = {
 			},
 		],
 
+		// eslint-plugin-depend
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					// axios replacement with fetch is ongoing: https://github.com/microsoft/FluidFramework/pull/25592
+					"axios",
+
+					// fs-extra is well-maintained and provides a useful readJson/writeJson API which is what we mainly use.
+					"fs-extra",
+				],
+			},
+		],
+
 		// #region eslint-plugin-import-x
 
 		"import-x/no-default-export": "error",
diff --git a/common/build/eslint-config-fluid/pnpm-lock.yaml b/common/build/eslint-config-fluid/pnpm-lock.yaml
diff --git a/common/build/eslint-config-fluid/printed-configs/default.json b/common/build/eslint-config-fluid/printed-configs/default.json
@@ -1072,7 +1072,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/minimal.json b/common/build/eslint-config-fluid/printed-configs/minimal.json
@@ -1053,7 +1053,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/react.json b/common/build/eslint-config-fluid/printed-configs/react.json
@@ -1074,7 +1074,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/recommended.json b/common/build/eslint-config-fluid/printed-configs/recommended.json
@@ -1072,7 +1072,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/strict-biome.json b/common/build/eslint-config-fluid/printed-configs/strict-biome.json
@@ -1145,7 +1145,13 @@
             "off"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/strict.json b/common/build/eslint-config-fluid/printed-configs/strict.json
@@ -1082,7 +1082,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/common/build/eslint-config-fluid/printed-configs/test.json b/common/build/eslint-config-fluid/printed-configs/test.json
@@ -1063,7 +1063,13 @@
             "error"
         ],
         "depend/ban-dependencies": [
-            "error"
+            "error",
+            {
+                "allowed": [
+                    "axios",
+                    "fs-extra"
+                ]
+            }
         ],
         "dot-location": [
             "off"
diff --git a/examples/external-data/.eslintrc.cjs b/examples/external-data/.eslintrc.cjs
@@ -19,6 +19,15 @@ module.exports = {
 		// TODO: AB#18875 - Re-enable react/no-deprecated once we replace uses of the deprecated ReactDOM.render()
 		// with the new React 18 createRoot().
 		"react/no-deprecated": "off",
+
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					"lodash.isequal",
+				],
+			},
+		],
 	},
 	overrides: [
 		{
diff --git a/experimental/PropertyDDS/packages/property-changeset/.eslintrc.cjs b/experimental/PropertyDDS/packages/property-changeset/.eslintrc.cjs
@@ -54,6 +54,16 @@ module.exports = {
 		"tsdoc/syntax": "off",
 		"unicorn/better-regex": "off",
 		"unicorn/filename-case": "off",
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					"lodash",
+					"traverse",
+				],
+			},
+		],
+
 		"@fluid-internal/fluid/no-unchecked-record-access": "warn",
 	},
 };
diff --git a/experimental/PropertyDDS/packages/property-common/.eslintrc.cjs b/experimental/PropertyDDS/packages/property-common/.eslintrc.cjs
@@ -15,5 +15,13 @@ module.exports = {
 		"@fluid-internal/fluid/no-unchecked-record-access": "warn",
 		"prefer-arrow-callback": "off",
 		"tsdoc/syntax": "off",
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					"lodash",
+				],
+			},
+		],
 	},
 };
diff --git a/experimental/PropertyDDS/packages/property-dds/.eslintrc.cjs b/experimental/PropertyDDS/packages/property-dds/.eslintrc.cjs
@@ -15,5 +15,14 @@ module.exports = {
 		"@typescript-eslint/strict-boolean-expressions": "off",
 		"tsdoc/syntax": "off",
 		"@fluid-internal/fluid/no-unchecked-record-access": "warn",
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					"axios",
+					"lodash",
+				],
+			},
+		],
 	},
 };
diff --git a/experimental/PropertyDDS/packages/property-properties/.eslintrc.cjs b/experimental/PropertyDDS/packages/property-properties/.eslintrc.cjs
@@ -56,6 +56,15 @@ module.exports = {
 		"quote-props": "off",
 		"tsdoc/syntax": "off",
 		"unicorn/better-regex": "off",
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					"lodash",
+					"underscore",
+				],
+			},
+		],
 
 		"@fluid-internal/fluid/no-unchecked-record-access": "warn",
 	},
diff --git a/packages/dds/test-dds-utils/.eslintrc.cjs b/packages/dds/test-dds-utils/.eslintrc.cjs
@@ -24,5 +24,16 @@ module.exports = {
 		],
 		"@typescript-eslint/no-import-type-side-effects": "error",
 		// #endregion
+
+		"depend/ban-dependencies": [
+			"error",
+			{
+				allowed: [
+					// TODO: This package should use tinyexec or child_process directly instead of execa
+					"execa",
+				],
+			},
+		],
+
 	},
 };
