refactor: Fix linter violations

Author: Josmithr

examples/apps/task-selection/src/app.ts

@@ -37,6 +37,7 @@ async function start(): Promise<void> {
 	}
 
 	// update the browser URL and the window title with the actual container ID
+	// eslint-disable-next-line require-atomic-updates
 	location.hash = id;
 	document.title = id;
 

examples/apps/task-selection/src/containerCode.ts

@@ -51,7 +51,7 @@ export class TaskSelectionContainerRuntimeFactory extends ModelContainerRuntimeF
 	/**
 	 * {@inheritDoc ModelContainerRuntimeFactory.containerInitializingFirstTime}
 	 */
-	protected async containerInitializingFirstTime(runtime: IContainerRuntime) {
+	protected async containerInitializingFirstTime(runtime: IContainerRuntime): Promise<void> {
 		const taskManagerDiceRoller = await runtime.createDataStore(
 			TaskManagerDiceRollerInstantiationFactory.type,
 		);
@@ -65,7 +65,10 @@ export class TaskSelectionContainerRuntimeFactory extends ModelContainerRuntimeF
 	/**
 	 * {@inheritDoc ModelContainerRuntimeFactory.createModel}
 	 */
-	protected async createModel(runtime: IContainerRuntime, container: IContainer) {
+	protected async createModel(
+		runtime: IContainerRuntime,
+		container: IContainer,
+	): Promise<ITaskSelectionAppModel> {
 		return new TaskSelectionAppModel(
 			await getDataStoreEntryPoint<IDiceRoller>(runtime, taskManagerDiceId),
 			await getDataStoreEntryPoint<IDiceRoller>(runtime, oldestClientDiceId),

examples/apps/task-selection/src/oldestClientDiceRoller.ts

@@ -24,15 +24,15 @@ export class OldestClientDiceRoller extends DataObject implements IDiceRoller {
 	 * initializingFirstTime is run only once by the first client to create the DataObject.  Here we use it to
 	 * initialize the state of the DataObject.
 	 */
-	protected async initializingFirstTime() {
+	protected async initializingFirstTime(): Promise<void> {
 		this.root.set(diceValueKey, 1);
 	}
 
 	/**
 	 * hasInitialized is run by each client as they load the DataObject.  Here we use it to set up usage of the
 	 * DataObject, by registering an event listener for dice rolls.
 	 */
-	protected async hasInitialized() {
+	protected async hasInitialized(): Promise<void> {
 		this.root.on("valueChanged", (changed) => {
 			if (changed.key === diceValueKey) {
 				// When we see the dice value change, we'll emit the diceRolled event we specified in our interface.
@@ -46,23 +46,23 @@ export class OldestClientDiceRoller extends DataObject implements IDiceRoller {
 		this.volunteerForAutoRoll();
 	}
 
-	private get oldestClientObserver() {
+	private get oldestClientObserver(): OldestClientObserver {
 		assert(this._oldestClientObserver !== undefined, "OldestClientObserver not initialized");
 		return this._oldestClientObserver;
 	}
 
-	public get value() {
+	public get value(): number {
 		const value = this.root.get<number>(diceValueKey);
 		assert(value !== undefined, "Dice value not initialized");
 		return value;
 	}
 
-	public readonly roll = () => {
+	public readonly roll = (): void => {
 		const rollValue = Math.floor(Math.random() * 6) + 1;
 		this.root.set(diceValueKey, rollValue);
 	};
 
-	public volunteerForAutoRoll() {
+	public volunteerForAutoRoll(): void {
 		if (this.oldestClientObserver.isOldest()) {
 			// If we're oldest, start the autoroll and watch for loss of oldest.
 			this.oldestClientObserver.once("lostOldest", () => {
@@ -80,7 +80,7 @@ export class OldestClientDiceRoller extends DataObject implements IDiceRoller {
 		}
 	}
 
-	private startAutoRollTask() {
+	private startAutoRollTask(): void {
 		console.log("Starting autoroll from OldestClientDiceRoller");
 		if (this.autoRollInterval === undefined) {
 			this.autoRollInterval = setInterval(() => {
@@ -89,15 +89,15 @@ export class OldestClientDiceRoller extends DataObject implements IDiceRoller {
 		}
 	}
 
-	private endAutoRollTask() {
+	private endAutoRollTask(): void {
 		console.log("Ending autoroll from OldestClientDiceRoller");
 		if (this.autoRollInterval !== undefined) {
 			clearInterval(this.autoRollInterval);
 			this.autoRollInterval = undefined;
 		}
 	}
 
-	public hasTask() {
+	public hasTask(): boolean {
 		return this.oldestClientObserver.isOldest();
 	}
 }

examples/apps/task-selection/src/taskManagerDiceRoller.ts

@@ -26,7 +26,7 @@ export class TaskManagerDiceRoller extends DataObject implements IDiceRoller {
 	 * initializingFirstTime is run only once by the first client to create the DataObject.  Here we use it to
 	 * initialize the state of the DataObject.
 	 */
-	protected async initializingFirstTime() {
+	protected async initializingFirstTime(): Promise<void> {
 		this.root.set(diceValueKey, 1);
 
 		// We create a TaskManager just like any other DDS.
@@ -38,7 +38,7 @@ export class TaskManagerDiceRoller extends DataObject implements IDiceRoller {
 	 * hasInitialized is run by each client as they load the DataObject.  Here we use it to set up usage of the
 	 * DataObject, by registering an event listener for dice rolls.
 	 */
-	protected async hasInitialized() {
+	protected async hasInitialized(): Promise<void> {
 		this.root.on("valueChanged", (changed) => {
 			if (changed.key === diceValueKey) {
 				// When we see the dice value change, we'll emit the diceRolled event we specified in our interface.
@@ -52,23 +52,23 @@ export class TaskManagerDiceRoller extends DataObject implements IDiceRoller {
 		this.subscribeToAutoRoll();
 	}
 
-	private get taskManager() {
+	private get taskManager(): TaskManager {
 		assert(this._taskManager !== undefined, "TaskManager not initialized");
 		return this._taskManager;
 	}
 
-	public get value() {
+	public get value(): number {
 		const value = this.root.get<number>(diceValueKey);
 		assert(value !== undefined, "Dice value not initialized");
 		return value;
 	}
 
-	public readonly roll = () => {
+	public readonly roll = (): void => {
 		const rollValue = Math.floor(Math.random() * 6) + 1;
 		this.root.set(diceValueKey, rollValue);
 	};
 
-	public subscribeToAutoRoll() {
+	public subscribeToAutoRoll(): void {
 		// Subscribe to the auto roll task. This will constantly keep us in queue for the task until we get it. If we
 		// lose the task assignment we will automatically re-enter queue.
 
@@ -89,7 +89,7 @@ export class TaskManagerDiceRoller extends DataObject implements IDiceRoller {
 		this.taskManager.subscribeToTask(autoRollTaskId);
 	}
 
-	private startAutoRollTask() {
+	private startAutoRollTask(): void {
 		console.log("Starting autoroll from TaskManagerDiceRoller");
 		if (this.autoRollInterval === undefined) {
 			this.autoRollInterval = setInterval(() => {
@@ -98,15 +98,15 @@ export class TaskManagerDiceRoller extends DataObject implements IDiceRoller {
 		}
 	}
 
-	private endAutoRollTask() {
+	private endAutoRollTask(): void {
 		console.log("Ending autoroll from TaskManagerDiceRoller");
 		if (this.autoRollInterval !== undefined) {
 			clearInterval(this.autoRollInterval);
 			this.autoRollInterval = undefined;
 		}
 	}
 
-	public hasTask() {
+	public hasTask(): boolean {
 		return this.taskManager.assigned(autoRollTaskId);
 	}
 }

examples/apps/task-selection/src/view.ts

@@ -30,15 +30,15 @@ export function renderDiceRoller(diceRoller: IDiceRoller, div: HTMLDivElement):
 	wrapperDiv.append(diceCharDiv, rollButton, taskOwnerDiv);
 
 	// Get the current value of the shared data to update the view whenever it changes.
-	const updateDiceChar = () => {
+	const updateDiceChar = (): void => {
 		// Unicode 0x2680-0x2685 are the sides of a dice (⚀⚁⚂⚃⚄⚅)
 		diceCharDiv.textContent = String.fromCodePoint(0x267f + diceRoller.value);
 		diceCharDiv.style.color = `hsl(${diceRoller.value * 60}, 70%, 50%)`;
 	};
 	updateDiceChar();
 
 	// Just showing visually whether we're the task owner or not.
-	const updateTaskOwner = () => {
+	const updateTaskOwner = (): void => {
 		taskOwnerDiv.textContent = diceRoller.hasTask() ? "Task owner" : "Not task owner";
 	};
 	updateTaskOwner();