Skip to content

Commit 7cbd4a8

Browse files
tylerbutlertylerbutler
authored
build(eslint-config-fluid): migrate to @eslint-community/eslint-plugin-eslint-comments (#25662)
More context: #25628 Migrate to the community-maintained version as the original is archived and no longer maintained.
1 parent 2d9dcd5 commit 7cbd4a8

File tree

19 files changed

+184
-174
lines changed

19 files changed

+184
-174
lines changed

‎common/build/eslint-config-fluid/CHANGELOG.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# @fluidframework/eslint-config-fluid Changelog
22

3+
## [9.0.0](https://github.com/microsoft/FluidFramework/releases/tag/eslint-config-fluid_v9.0_0)
4+
5+
### eslint-plugin-eslint-comments replaced by @eslint-community/eslint-plugin-eslint-comments
6+
7+
The package now uses rules from
8+
[@eslint-community/eslint-plugin-eslint-comments](https://eslint-community.github.io/eslint-plugin-eslint-comments/)
9+
v4.5.0 instead of eslint-plugin-eslint-comments v3.2.0. Integrating this change will require renaming eslint disable
10+
comments and overrides, but the changes are mechanical.
11+
312
## [8.1.0](https://github.com/microsoft/FluidFramework/releases/tag/eslint-config-fluid_v8.1.0)
413

514
### import-x/order rule simplified

‎common/build/eslint-config-fluid/base.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = {
1515
},
1616
extends: [
1717
"eslint:recommended",
18-
"plugin:eslint-comments/recommended",
18+
"plugin:@eslint-community/eslint-comments/recommended",
1919
"plugin:@typescript-eslint/eslint-recommended",
2020
"plugin:@typescript-eslint/recommended-type-checked",
2121
"plugin:@typescript-eslint/stylistic-type-checked",
@@ -160,8 +160,8 @@ module.exports = {
160160

161161
// #endregion
162162

163-
// eslint-plugin-eslint-comments
164-
"eslint-comments/disable-enable-pair": [
163+
// @eslint-community/eslint-plugin-eslint-comments
164+
"@eslint-community/eslint-comments/disable-enable-pair": [
165165
"error",
166166
{
167167
allowWholeFile: true,

‎common/build/eslint-config-fluid/minimal-deprecated.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ module.exports = {
6969
es2024: false,
7070
node: true,
7171
},
72-
extends: ["./base", "plugin:eslint-comments/recommended", "prettier"],
72+
extends: ["./base", "prettier"],
7373
globals: {
7474
Atomics: "readonly",
7575
SharedArrayBuffer: "readonly",
@@ -154,7 +154,7 @@ module.exports = {
154154
/**
155155
* Encourages minimal disabling of eslint rules, while still permitting whole-file exclusions.
156156
*/
157-
"eslint-comments/disable-enable-pair": [
157+
"@eslint-community/eslint-comments/disable-enable-pair": [
158158
"error",
159159
{
160160
allowWholeFile: true,

‎common/build/eslint-config-fluid/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
"tsc": "npm run build"
3333
},
3434
"dependencies": {
35+
"@eslint-community/eslint-plugin-eslint-comments": "~4.5.0",
3536
"@fluid-internal/eslint-plugin-fluid": "^0.4.0",
3637
"@rushstack/eslint-patch": "~1.12.0",
3738
"@rushstack/eslint-plugin": "~0.19.0",
@@ -41,7 +42,6 @@
4142
"eslint-config-biome": "~2.1.3",
4243
"eslint-config-prettier": "~10.1.8",
4344
"eslint-import-resolver-typescript": "~4.4.4",
44-
"eslint-plugin-eslint-comments": "~3.2.0",
4545
"eslint-plugin-import-x": "~4.16.1",
4646
"eslint-plugin-jsdoc": "~55.0.2",
4747
"eslint-plugin-promise": "~7.2.1",

‎common/build/eslint-config-fluid/pnpm-lock.yaml‎

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎common/build/eslint-config-fluid/printed-configs/default.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"sourceType": "module"
2323
},
2424
"plugins": [
25+
"@eslint-community/eslint-comments",
2526
"import-x",
26-
"eslint-comments",
2727
"@fluid-internal/fluid",
2828
"unused-imports",
2929
"promise",
@@ -42,6 +42,24 @@
4242
"@babel/semi": [
4343
"off"
4444
],
45+
"@eslint-community/eslint-comments/disable-enable-pair": [
46+
"error",
47+
{
48+
"allowWholeFile": true
49+
}
50+
],
51+
"@eslint-community/eslint-comments/no-aggregating-enable": [
52+
"error"
53+
],
54+
"@eslint-community/eslint-comments/no-duplicate-disable": [
55+
"error"
56+
],
57+
"@eslint-community/eslint-comments/no-unlimited-disable": [
58+
"error"
59+
],
60+
"@eslint-community/eslint-comments/no-unused-enable": [
61+
"error"
62+
],
4563
"@fluid-internal/fluid/no-file-path-links-in-jsdoc": [
4664
"error"
4765
],
@@ -1074,24 +1092,6 @@
10741092
"error",
10751093
"smart"
10761094
],
1077-
"eslint-comments/disable-enable-pair": [
1078-
"error",
1079-
{
1080-
"allowWholeFile": true
1081-
}
1082-
],
1083-
"eslint-comments/no-aggregating-enable": [
1084-
"error"
1085-
],
1086-
"eslint-comments/no-duplicate-disable": [
1087-
"error"
1088-
],
1089-
"eslint-comments/no-unlimited-disable": [
1090-
"error"
1091-
],
1092-
"eslint-comments/no-unused-enable": [
1093-
"error"
1094-
],
10951095
"flowtype/boolean-style": [
10961096
"off"
10971097
],

‎common/build/eslint-config-fluid/printed-configs/minimal.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"sourceType": "module"
2323
},
2424
"plugins": [
25+
"@eslint-community/eslint-comments",
2526
"import-x",
26-
"eslint-comments",
2727
"@fluid-internal/fluid",
2828
"unicorn",
2929
"unused-imports",
@@ -42,6 +42,24 @@
4242
"@babel/semi": [
4343
"off"
4444
],
45+
"@eslint-community/eslint-comments/disable-enable-pair": [
46+
"error",
47+
{
48+
"allowWholeFile": true
49+
}
50+
],
51+
"@eslint-community/eslint-comments/no-aggregating-enable": [
52+
"error"
53+
],
54+
"@eslint-community/eslint-comments/no-duplicate-disable": [
55+
"error"
56+
],
57+
"@eslint-community/eslint-comments/no-unlimited-disable": [
58+
"error"
59+
],
60+
"@eslint-community/eslint-comments/no-unused-enable": [
61+
"error"
62+
],
4563
"@fluid-internal/fluid/no-file-path-links-in-jsdoc": [
4664
"error"
4765
],
@@ -1055,24 +1073,6 @@
10551073
"error",
10561074
"smart"
10571075
],
1058-
"eslint-comments/disable-enable-pair": [
1059-
"error",
1060-
{
1061-
"allowWholeFile": true
1062-
}
1063-
],
1064-
"eslint-comments/no-aggregating-enable": [
1065-
"error"
1066-
],
1067-
"eslint-comments/no-duplicate-disable": [
1068-
"error"
1069-
],
1070-
"eslint-comments/no-unlimited-disable": [
1071-
"error"
1072-
],
1073-
"eslint-comments/no-unused-enable": [
1074-
"error"
1075-
],
10761076
"flowtype/boolean-style": [
10771077
"off"
10781078
],

‎common/build/eslint-config-fluid/printed-configs/react.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"sourceType": "module"
2323
},
2424
"plugins": [
25+
"@eslint-community/eslint-comments",
2526
"import-x",
26-
"eslint-comments",
2727
"@fluid-internal/fluid",
2828
"unused-imports",
2929
"promise",
@@ -44,6 +44,24 @@
4444
"@babel/semi": [
4545
"off"
4646
],
47+
"@eslint-community/eslint-comments/disable-enable-pair": [
48+
"error",
49+
{
50+
"allowWholeFile": true
51+
}
52+
],
53+
"@eslint-community/eslint-comments/no-aggregating-enable": [
54+
"error"
55+
],
56+
"@eslint-community/eslint-comments/no-duplicate-disable": [
57+
"error"
58+
],
59+
"@eslint-community/eslint-comments/no-unlimited-disable": [
60+
"error"
61+
],
62+
"@eslint-community/eslint-comments/no-unused-enable": [
63+
"error"
64+
],
4765
"@fluid-internal/fluid/no-file-path-links-in-jsdoc": [
4866
"error"
4967
],
@@ -1076,24 +1094,6 @@
10761094
"error",
10771095
"smart"
10781096
],
1079-
"eslint-comments/disable-enable-pair": [
1080-
"error",
1081-
{
1082-
"allowWholeFile": true
1083-
}
1084-
],
1085-
"eslint-comments/no-aggregating-enable": [
1086-
"error"
1087-
],
1088-
"eslint-comments/no-duplicate-disable": [
1089-
"error"
1090-
],
1091-
"eslint-comments/no-unlimited-disable": [
1092-
"error"
1093-
],
1094-
"eslint-comments/no-unused-enable": [
1095-
"error"
1096-
],
10971097
"flowtype/boolean-style": [
10981098
"off"
10991099
],

‎common/build/eslint-config-fluid/printed-configs/recommended.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"sourceType": "module"
2323
},
2424
"plugins": [
25+
"@eslint-community/eslint-comments",
2526
"import-x",
26-
"eslint-comments",
2727
"@fluid-internal/fluid",
2828
"unused-imports",
2929
"promise",
@@ -42,6 +42,24 @@
4242
"@babel/semi": [
4343
"off"
4444
],
45+
"@eslint-community/eslint-comments/disable-enable-pair": [
46+
"error",
47+
{
48+
"allowWholeFile": true
49+
}
50+
],
51+
"@eslint-community/eslint-comments/no-aggregating-enable": [
52+
"error"
53+
],
54+
"@eslint-community/eslint-comments/no-duplicate-disable": [
55+
"error"
56+
],
57+
"@eslint-community/eslint-comments/no-unlimited-disable": [
58+
"error"
59+
],
60+
"@eslint-community/eslint-comments/no-unused-enable": [
61+
"error"
62+
],
4563
"@fluid-internal/fluid/no-file-path-links-in-jsdoc": [
4664
"error"
4765
],
@@ -1074,24 +1092,6 @@
10741092
"error",
10751093
"smart"
10761094
],
1077-
"eslint-comments/disable-enable-pair": [
1078-
"error",
1079-
{
1080-
"allowWholeFile": true
1081-
}
1082-
],
1083-
"eslint-comments/no-aggregating-enable": [
1084-
"error"
1085-
],
1086-
"eslint-comments/no-duplicate-disable": [
1087-
"error"
1088-
],
1089-
"eslint-comments/no-unlimited-disable": [
1090-
"error"
1091-
],
1092-
"eslint-comments/no-unused-enable": [
1093-
"error"
1094-
],
10951095
"flowtype/boolean-style": [
10961096
"off"
10971097
],

0 commit comments

Comments
 (0)