Skip to content

Commit 96e58d1

Browse files
authored
fix(test-drivers): use valid URL for hostUrl in docker config (#25837)
## Description In PR #25610, the `hostUrl` in the docker config was set to `'this value is unused'` with a comment indicating it didn't seem to matter. However, it turns out that the URL does need to be a valid URL. This change fixes the issue by setting `hostUrl` to `http://localhost:3003`, which matches the alfred service URL (same as `ordererUrl`). Alfred is the main service endpoint in the docker setup, accessible via the nginx proxy on port 3003. ## Changes - Updated `hostUrl` from `'this value is unused'` to `http://localhost:3003` in the docker config - Removed the misleading comment about the value being unused
1 parent 8c294b4 commit 96e58d1

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/test/test-drivers/src/routerliciousTestDriver.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ interface IServiceEndpoint {
3131
const dockerConfig = (driverPolicies?: IRouterliciousDriverPolicies) => ({
3232
serviceEndpoint: {
3333
deltaStreamUrl: "http://localhost:3002",
34-
// The 'hostUrl' value doesn't seem to matter for this driver.
35-
hostUrl: "this value is unused",
34+
hostUrl: "http://localhost:3003",
3635
ordererUrl: "http://localhost:3003",
3736
deltaStorageUrl: "http://localhost:3001",
3837
},

0 commit comments

Comments
 (0)