Tag Asserts (#24892)

## Description

Tag asserts for release

Author: CraigMacomber

packages/dds/sequence/src/intervalCollection.ts

@@ -699,18 +699,18 @@ function removeMetadataFromPendingChanges(
 ): IntervalMessageLocalMetadata {
 	const acked = (localOpMetadataNode as ListNode<IntervalMessageLocalMetadata>)?.remove()
 		?.data;
-	assert(acked !== undefined, "local change must exist");
+	assert(acked !== undefined, 0xbbe /* local change must exist */);
 	acked.endpointChangesNode?.remove();
 	return acked;
 }
 
 function clearEmptyPendingEntry(pendingChanges: PendingChanges, id: string) {
 	const pending = pendingChanges[id];
-	assert(pending !== undefined, "pending must exist for local process");
+	assert(pending !== undefined, 0xbbf /* pending must exist for local process */);
 	if (pending.local.empty) {
 		assert(
 			pending.endpointChanges?.empty !== false,
-			"endpointChanges must be empty if not pending changes",
+			0xbc0 /* endpointChanges must be empty if not pending changes */,
 		);
 		// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
 		delete pendingChanges[id];
@@ -868,7 +868,7 @@ export class IntervalCollection
 		const { opName, value } = op;
 		assert(
 			(local === false && localOpMetadata === undefined) || opName === localOpMetadata?.type,
-			"must be same type",
+			0xbc1 /* must be same type */,
 		);
 		switch (opName) {
 			case "add": {

packages/dds/tree/src/shared-tree/schematizingTreeView.ts

@@ -528,7 +528,7 @@ export function addConstraintsToTransaction(
 						`Attempted to add a "nodeInDocument" constraint${revertText}, but the node is not currently in the document. Node status: ${nodeStatus}`,
 					);
 				}
-				assert(node.isHydrated(), "In document node must be hydrated.");
+				assert(node.isHydrated(), 0xbc2 /* In document node must be hydrated. */);
 				if (constraintsOnRevert) {
 					checkout.editor.addNodeExistsConstraintOnRevert(node.anchorNode);
 				} else {

packages/dds/tree/src/shared-tree/treeAlpha.ts

@@ -611,7 +611,7 @@ export const TreeAlpha: TreeAlpha = {
 				return undefined;
 			}
 			case NodeKind.Leaf: {
-				fail("Leaf schema associated with non-leaf tree node.");
+				fail(0xbc3 /* Leaf schema associated with non-leaf tree node. */);
 			}
 			default: {
 				unreachableCase(schema.kind);
@@ -637,7 +637,7 @@ export const TreeAlpha: TreeAlpha = {
 
 				for (let index = 0; index < sequence.length; index++) {
 					const childFlexTree = sequence.at(index);
-					assert(childFlexTree !== undefined, "Sequence child was undefined.");
+					assert(childFlexTree !== undefined, 0xbc4 /* Sequence child was undefined. */);
 					const childTree = getOrCreateNodeFromInnerUnboxedNode(childFlexTree);
 					result.push([index, childTree]);
 				}
@@ -653,20 +653,23 @@ export const TreeAlpha: TreeAlpha = {
 				break;
 			}
 			case NodeKind.Object: {
-				assert(isObjectNodeSchema(schema), "Expected object schema.");
+				assert(isObjectNodeSchema(schema), 0xbc5 /* Expected object schema. */);
 				for (const [propertyKey, fieldSchema] of schema.fields) {
 					const storedKey = fieldSchema.storedKey;
 					const flexField = flexNode.tryGetField(brand(String(storedKey)));
 					if (flexField !== undefined) {
 						const childTreeNode = tryGetTreeNodeForField(flexField);
-						assert(childTreeNode !== undefined, "Expected child tree node for field.");
+						assert(
+							childTreeNode !== undefined,
+							0xbc6 /* Expected child tree node for field. */,
+						);
 						result.push([propertyKey, childTreeNode]);
 					}
 				}
 				break;
 			}
 			case NodeKind.Leaf: {
-				fail("Leaf schema associated with non-leaf tree node.");
+				fail(0xbc7 /* Leaf schema associated with non-leaf tree node. */);
 			}
 			default: {
 				unreachableCase(schema.kind);

packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts

@@ -372,7 +372,7 @@ export function splitInnerNodeType(
 ): asserts innerNode is UnhydratedFlexTreeNode | HydratedFlexTreeNode {
 	assert(
 		innerNode instanceof UnhydratedFlexTreeNode || innerNode.isHydrated(),
-		"Invalid inner node type",
+		0xbc8 /* Invalid inner node type */,
 	);
 }
 

packages/dds/tree/src/simple-tree/core/treeNodeSchema.ts

@@ -419,11 +419,11 @@ export function asTreeNodeSchemaCorePrivate(
 ): TreeNodeSchemaCorePrivate {
 	assert(
 		"childAnnotatedAllowedTypes" in schema,
-		"All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate",
+		0xbc9 /* All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate */,
 	);
 	assert(
 		Array.isArray((schema as TreeNodeSchemaCorePrivate).childAnnotatedAllowedTypes),
-		"All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate",
+		0xbca /* All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate */,
 	);
 	return schema as TreeNodeSchemaCorePrivate;
 }

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -322,7 +322,6 @@ export const shortCodeMap = {
 	"0x1dd": "no epoch",
 	"0x1de": "Not an ODSP resolved url",
 	"0x1e2": "Caller must ensure 'isAttached()' before calling 'sendSetCellOp'.",
-	"0x1e4": "Unexpected serializable type",
 	"0x1e5": "Storage token should not be null",
 	"0x1e6": "Epoch  should be present in response",
 	"0x1e7": "caching was not performed!",
@@ -752,11 +751,7 @@ export const shortCodeMap = {
 	"0x543": "should be at selected child",
 	"0x54c": "Container already disposed",
 	"0x54d": "Removed segment that hasnt had its removal acked should be locally removed",
-	"0x54e": "No segment found",
-	"0x54f": "Invalid offset",
 	"0x550": "Client should be defined when computing rebased position",
-	"0x551": "Failed to store pending serialized interval info for this localSeq.",
-	"0x552": "op metadata should be defined for local op",
 	"0x553": "op metadata should be defined for local op",
 	"0x554": "Last pending message cannot be a batch begin",
 	"0x555": "No batch end found",
@@ -1732,9 +1727,6 @@ export const shortCodeMap = {
 	"0xb42": "Expected anchor node to be present",
 	"0xb45": "missing context",
 	"0xb46": "missing schema",
-	"0xb47": "UnhydratedFlexTreeNode does not implement anchorNode",
-	"0xb48": "unsupported",
-	"0xb49": "unsupported",
 	"0xb4a": "Expected removed to be set by edit",
 	"0xb4b": "encoder interface instead of shape written to stream",
 	"0xb4c": "missing shape",
@@ -1781,13 +1773,10 @@ export const shortCodeMap = {
 	"0xb79": "grouping disabled!",
 	"0xb7a": "Unexpected attempt to group an empty batch",
 	"0xb7b": "Flushing must not happen while incoming changes are being processed",
-	"0xb7c": "must have previous for change",
-	"0xb7d": "must have previous for delete",
 	"0xb7e": "Local value expected on rollback",
 	"0xb7f": "Expected a recorded refSeq when rolling back an op",
 	"0xb80": "Double disposed",
 	"0xb81": "disposed",
-	"0xb82": "Staged batches expected to have runtimeOp defined",
 	"0xb83": "Invalid delta manager",
 	"0xb84": "Staged batches should not have been submitted",
 	"0xb85": "Pending state mismatch, ack came in but next pending message is staged",
@@ -1833,7 +1822,6 @@ export const shortCodeMap = {
 	"0xbad": "Last remove should be the obliterate that is being resubmitted.",
 	"0xbae": "Last remove should be the obliterate that is being resubmitted.",
 	"0xbaf": "Expected only one local remove",
-	"0xbb0": "both start and end must be set or unset",
 	"0xbb1": "missing field has no default provider",
 	"0xbb2": "Invalid field kind",
 	"0xbb3": "invalid map tree: empty field",
@@ -1846,5 +1834,18 @@ export const shortCodeMap = {
 	"0xbba": "Unexpected message type submitted in Staging Mode",
 	"0xbbb": "Expected message type to be compatible with staging",
 	"0xbbc": "Unexpected message type to be rolled back",
-	"0xbbd": "pendingOpCount must be non-negative"
+	"0xbbd": "pendingOpCount must be non-negative",
+	"0xbbe": "local change must exist",
+	"0xbbf": "pending must exist for local process",
+	"0xbc0": "endpointChanges must be empty if not pending changes",
+	"0xbc1": "must be same type",
+	"0xbc2": "In document node must be hydrated.",
+	"0xbc3": "Leaf schema associated with non-leaf tree node.",
+	"0xbc4": "Sequence child was undefined.",
+	"0xbc5": "Expected object schema.",
+	"0xbc6": "Expected child tree node for field.",
+	"0xbc7": "Leaf schema associated with non-leaf tree node.",
+	"0xbc8": "Invalid inner node type",
+	"0xbc9": "All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate",
+	"0xbca": "All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate"
 };