-
Notifications
You must be signed in to change notification settings - Fork 559
feat(build-tools): add Biome 2.x configuration reader #25969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylerbutler
wants to merge
31
commits into
microsoft:main
Choose a base branch
from
tylerbutler:copilot/update-biomeconfigreader-for-2-x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,646
−41
Open
Changes from 8 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
04f754e
Initial plan
Copilot 7258553
Add Biome 2.x configuration reader with version detection and unified…
Copilot 3054c4b
Fix double-prefixing of glob patterns that already start with **/ and…
Copilot e0460db
Address review feedback: remove re-exports, remove unused function, a…
Copilot f928ee0
Add root field support for Biome 2.x config and tests for nested conf…
Copilot e25bf13
Address code review: improve docstrings and simplify test assertion
Copilot 8b6e276
Add code sharing for extends resolution and test for combined extends…
Copilot 2ff05a2
Improve code review feedback: add includeConfigPath param and fix uns…
Copilot 07bfffa
use json schema to generate types
tylerbutler 80ee3d7
type fixes
tylerbutler a02357c
Merge branch 'main' into copilot/update-biomeconfigreader-for-2-x
tylerbutler 29cb8bc
Address review feedback: add stopAt param, improve docs, share filter…
Copilot 872b1ec
Clarify stopAt param documentation in findParentBiome2Configs
Copilot fa2c614
Rename class to BiomeConfigReaderV1, interface to BiomeConfigReader, …
Copilot ac756d9
Use createBiomeConfigReader factory in BiomeTask for auto-detection
Copilot c1bd1e8
Document globstar limitation and add tests for negation pattern ordering
Copilot e9ef09d
Implement ordered pattern processing for correct re-inclusion support…
Copilot 514c658
Fix re-inclusion logic: use multimatch instead of ignore for include …
Copilot 00ea3ff
Merge branch 'main' into copilot/update-biomeconfigreader-for-2-x
tylerbutler a47ecf0
Merge branch 'main' into copilot/update-biomeconfigreader-for-2-x
tylerbutler 5e95bd8
policy
tylerbutler cee35e8
fixes
tylerbutler e9f11a5
unused var
tylerbutler fafd093
handle // microsyntax
tylerbutler e7f13fa
refactor: separate v1 and v2 biome config implementations
tylerbutler 7a528f6
cleanup
tylerbutler 202fc6d
add tests
tylerbutler b32068b
fix test cases
tylerbutler 43e8a1e
ignore
tylerbutler 206c217
policy
tylerbutler 9eec8ac
fix(build-tools): address PR feedback for Biome 2.x config reader
tylerbutler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ | |
| "format": "npm run format:biome", | ||
| "format:biome": "biome check --write .", | ||
| "json-schema-to-typescript:biomeConfigTypes": "json2ts --input node_modules/@biomejs/biome/configuration_schema.json --output src/common/biomeConfigTypes.d.ts", | ||
| "json-schema-to-typescript:biome2ConfigTypes": "echo 'To generate Biome 2.x types, install @biomejs/[email protected] and run: json2ts --input node_modules/@biomejs/biome/configuration_schema.json --output src/common/biome2ConfigTypes.d.ts'", | ||
| "lint": "npm run eslint", | ||
| "lint:fix": "npm run eslint:fix", | ||
| "list-repo-files": "cd ../../.. && git ls-files -co --exclude-standard", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.