msi\setup.exe: Fix a handle leak #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisGuzak
approved these changes
Dec 1, 2025
| // cannot test return value of AdjustTokenPrivileges | ||
| if (ERROR_SUCCESS != WIN::GetLastError()) | ||
| { | ||
| CloseHandle(hToken); |
Member
There was a problem hiding this comment.
fix looks correct, using wil::unique_handle (is there wil::unique_htoken?) and RAII for all of the resource lifetimes would simplify further.
Author
There was a problem hiding this comment.
The code is too old, I guess here wil is unavailable, but that doesn't matter, an explicit call to CloseHandle can emphasize that it needs to be released. As an example, I think it is more important to show how to use this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The access token handle returned by
OpenProcessTokenshould be closed when no longer needed.