-
Notifications
You must be signed in to change notification settings - Fork 311
Update repo to use net10.0 #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
96bcffb
76a050b
dc28934
b248361
7cce402
b4cb0cf
7d31759
41b2e98
969cebf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,13 +13,6 @@ jobs: | |
| inputs: | ||
| useGlobalJson: true | ||
|
|
||
| - task: UseDotNet@2 | ||
| displayName: "Use .NET SDK 9.0.x" | ||
| retryCountOnTaskFailure: 3 | ||
| inputs: | ||
| packageType: sdk | ||
| version: 9.0.x | ||
|
Comment on lines
-16
to
-21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Depending how soon we want this PR in may still need this but be updated to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a task just above these that installs the version in global.json
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were having to also install 9.0 after 10-preview because we wanted 10.0-preview tooling, but a 9.0 dependency |
||
|
|
||
| - task: Powershell@2 | ||
| displayName: "Run source analysis" | ||
| inputs: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the following also be updated:
System.Formats.Asn1-> 10.0.0Microsoft.Extensions.AI.Abstractions-> 10.0.0Microsoft.Extensions.AI.Evaluation.Quality-> 10.0.0Microsoft.AspNetCore.SignalR.Client-> 10.0.0Microsoft.Extensions.Caching.Memory-> 10.0.0Microsoft.Extensions.Configuration-> 10.0.0Microsoft.Extensions.Configuration.EnvironmentVariables-> 10.0.0Microsoft.Extensions.Configuration.Json-> 10.0.0Microsoft.Extensions.DependencyInjection-> 10.0.0Microsoft.Extensions.Hosting-> 10.0.0System.CommandLine-> 2.0.0System.Numerics.Tensors-> 10.0.0System.Text.Json-> 10.0.0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, but now we get some new AOT failures:
https://dev.azure.com/azure-sdk/public/public%20Team/_build/results?buildId=5603241&view=logs&j=1e679852-4871-5dae-dd38-eb073eb853d4&t=3639d9f6-46e5-5c59-1fa3-9c261e132d8a&l=105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hallipr, could you update
Azure.ResourceManager.HDInsightto1.2.0-beta.5? I'll look intoAzure.AI.OpenAIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking with the .NET SDK team on
Microsoft.Extensions.AI.OpenAI. If this PR is urgent, we can keep the current version ofMicrosoft.Extensions.AI.OpenAIand just updateAzure.ResourceManager.HDInsightto 1.2.0-beta.5.