azure-pipelines: Add succeeded() conditions to signing template steps (#2143)

* Initial plan

* Add succeeded() conditions to all signing steps in sign.yml

Co-authored-by: bwateratmsft <[email protected]>

* Add signprojExists check to multiple vsix steps for consistency

Co-authored-by: bwateratmsft <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: bwateratmsft <[email protected]>

Author: Copilot

azure-pipelines/templates/sign.yml

@@ -19,25 +19,25 @@ steps:
           Write-Output "SignExtension.signproj file not found. Skipping signing."
       }
     displayName: "\U0001F449 Check for SignExtension.signproj File"
-    condition: ${{ parameters.enableSigning }}
+    condition: and(succeeded(), ${{ parameters.enableSigning }})
 
   # put the extension name and version from the package.json into variables to use later. Variables can be used in later steps as $(package.name) and $(package.version)
   - pwsh: |
       Write-Output "##vso[task.setvariable variable=name;isOutput=true]$((Get-Content -Raw -Path package.json | ConvertFrom-Json).name)"
       Write-Output "##vso[task.setvariable variable=version;isOutput=true]$((Get-Content -Raw -Path package.json | ConvertFrom-Json).version)"
-    condition: eq(variables['signprojExists'], True)
+    condition: and(succeeded(), eq(variables['signprojExists'], True))
     name: package
     displayName: "\U0001F449 Get extension info from package.json"
 
   # Sign single vsix file if vsixFileNames are not provided
   - ${{ if eq(join('', parameters.vsixFileNames), '') }}:
     - script: npx @vscode/vsce@latest generate-manifest -i $(package.name)-$(package.version).vsix -o $(Build.SourcesDirectory)/extension.manifest
-      condition: eq(variables['signprojExists'], True)
+      condition: and(succeeded(), eq(variables['signprojExists'], True))
       displayName: "\U0001F449 Generate extension manifest"
 
     # this task will pass even if signing fails, so we follow it up with a check to see if the signature file was created
     - task: DotNetCoreCLI@2
-      condition: eq(variables['signprojExists'], True)
+      condition: and(succeeded(), eq(variables['signprojExists'], True))
       displayName: "\U0001F449 Sign with MSBuild"
       inputs:
         command: 'build'
@@ -56,17 +56,19 @@ steps:
         Write-Output "The file '$filePath' exists."
         exit 0
       displayName: "\U0001F449 Verify extension.signature.p7s file was created"
-      condition: eq(variables['signprojExists'], True)
+      condition: and(succeeded(), eq(variables['signprojExists'], True))
 
   # If vsixFileNames are provided, sign each file in list and move to corresponding directory
   - ${{ if ne(join('', parameters.vsixFileNames), '') }}:
     # run this script for each item in vsixFileNames
     - ${{ each vsixFileName in parameters.vsixFileNames }}:
         - script: npx @vscode/vsce@latest generate-manifest -i ${{ vsixFileName }}-$(package.version).vsix -o $(Build.SourcesDirectory)/extension.manifest
+          condition: and(succeeded(), eq(variables['signprojExists'], True))
           displayName: "\U0001F449 Generate extension manifest for ${{ vsixFileName }}"
 
         # this task will pass even if signing fails, so we follow it up with a check to see if the signature file was created
         - task: DotNetCoreCLI@2
+          condition: and(succeeded(), eq(variables['signprojExists'], True))
           displayName: "\U0001F449 Sign with MSBuild for ${{ vsixFileName }}"
           inputs:
             command: 'build'
@@ -85,6 +87,7 @@ steps:
             Write-Output "The file '$filePath' exists."
             exit 0
           displayName: "\U0001F449 Verify extension.signature.p7s file was created for ${{ vsixFileName }}"
+          condition: and(succeeded(), eq(variables['signprojExists'], True))
 
         - pwsh: |
             $targetDir = "${{ vsixFileName }}"
@@ -93,3 +96,4 @@ steps:
             Move-Item -Path "extension.manifest" -Destination "$(Build.SourcesDirectory)/$targetDir/extension.manifest" -Force
             Write-Output "Moved signature files to $targetDir directory"
           displayName: "\U0001F449 Move signature files to ${{ vsixFileName }} directory"
+          condition: and(succeeded(), eq(variables['signprojExists'], True))