Skip to content

Commit 35c6bb7

Browse files
committed
Coding style fixes
Signed-off-by: Ted Xu <[email protected]>
1 parent 2857c7a commit 35c6bb7

File tree

2 files changed

+29
-20
lines changed

2 files changed

+29
-20
lines changed

internal/core/src/segcore/ChunkedSegmentSealedImpl.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,11 @@ ChunkedSegmentSealedImpl::LoadColumnGroup(
447447

448448
auto chunk_reader = std::move(chunk_reader_result).ValueOrDie();
449449

450-
LOG_INFO("[StorageV2] segment {} loads manifest cg index {} with aggregation factor 4",
451-
this->get_segment_id(),
452-
index);
450+
LOG_INFO(
451+
"[StorageV2] segment {} loads manifest cg index {} with aggregation "
452+
"factor 4",
453+
this->get_segment_id(),
454+
index);
453455

454456
auto manifest_translator =
455457
std::make_unique<storagev2translator::ManifestGroupTranslator>(
@@ -460,14 +462,14 @@ ChunkedSegmentSealedImpl::LoadColumnGroup(
460462
use_mmap,
461463
column_group->columns.size(),
462464
segment_load_info_.priority());
463-
465+
464466
// Wrap with AggregateTranslator for zero-copy aggregation
465467
auto translator =
466468
std::make_unique<storagev2translator::AggregateTranslator>(
467469
std::move(manifest_translator),
468470
4 // Default aggregation factor
469471
);
470-
472+
471473
auto chunked_column_group =
472474
std::make_shared<ChunkedColumnGroup>(std::move(translator));
473475

internal/core/src/segcore/storagev2translator/AggregateTranslatorTest.cpp

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@ namespace cachinglayer = milvus::cachinglayer;
4242
// Minimal mock ChunkReader for testing
4343
class MockChunkReader : public milvus_storage::api::ChunkReader {
4444
public:
45-
explicit MockChunkReader(size_t num_cells, const std::vector<int64_t>& rows_per_cell)
46-
: num_cells_(num_cells), rows_per_cell_(rows_per_cell) {}
45+
explicit MockChunkReader(size_t num_cells,
46+
const std::vector<int64_t>& rows_per_cell)
47+
: num_cells_(num_cells), rows_per_cell_(rows_per_cell) {
48+
}
4749

4850
size_t
4951
total_number_of_chunks() const override {
@@ -61,7 +63,8 @@ class MockChunkReader : public milvus_storage::api::ChunkReader {
6163
}
6264

6365
arrow::Result<std::vector<std::shared_ptr<arrow::RecordBatch>>>
64-
get_chunks(const std::vector<int64_t>& indices, int64_t parallel_degree) override {
66+
get_chunks(const std::vector<int64_t>& indices,
67+
int64_t parallel_degree) override {
6568
return arrow::Status::NotImplemented("Mock - use read_cells override");
6669
}
6770

@@ -142,14 +145,16 @@ class MockManifestGroupTranslator : public ManifestGroupTranslator {
142145
for (const auto& batch : record_batches) {
143146
int64_arrays.push_back(batch->column(0));
144147
}
145-
chunks[FieldId(1)] = create_chunk(field_metas.at(FieldId(1)), int64_arrays);
148+
chunks[FieldId(1)] =
149+
create_chunk(field_metas.at(FieldId(1)), int64_arrays);
146150

147151
// Field 2 (float)
148152
arrow::ArrayVector float_arrays;
149153
for (const auto& batch : record_batches) {
150154
float_arrays.push_back(batch->column(1));
151155
}
152-
chunks[FieldId(2)] = create_chunk(field_metas.at(FieldId(2)), float_arrays);
156+
chunks[FieldId(2)] =
157+
create_chunk(field_metas.at(FieldId(2)), float_arrays);
153158

154159
return std::make_unique<GroupChunk>(chunks);
155160
}
@@ -162,16 +167,18 @@ class MockManifestGroupTranslator : public ManifestGroupTranslator {
162167
static std::unordered_map<FieldId, FieldMeta>
163168
CreateFieldMetas() {
164169
std::unordered_map<FieldId, FieldMeta> field_metas;
165-
field_metas.emplace(FieldId(1), FieldMeta(FieldName("field1"),
166-
FieldId(1),
167-
DataType::INT64,
168-
false,
169-
std::nullopt));
170-
field_metas.emplace(FieldId(2), FieldMeta(FieldName("field2"),
171-
FieldId(2),
172-
DataType::FLOAT,
173-
false,
174-
std::nullopt));
170+
field_metas.emplace(FieldId(1),
171+
FieldMeta(FieldName("field1"),
172+
FieldId(1),
173+
DataType::INT64,
174+
false,
175+
std::nullopt));
176+
field_metas.emplace(FieldId(2),
177+
FieldMeta(FieldName("field2"),
178+
FieldId(2),
179+
DataType::FLOAT,
180+
false,
181+
std::nullopt));
175182
return field_metas;
176183
}
177184
};

0 commit comments

Comments
 (0)