Skip to content

Commit 9eac6a1

Browse files
authored
fix: update new_profile_activation_clients by removing isp field from select (#8521)
1 parent fddb4b1 commit 9eac6a1

File tree

5 files changed

+5
-10
lines changed
  • sql_generators/mobile_kpi_support_metrics/templates
  • tests/sql_generators/mobile_kpi_support_metrics/expected/moz-fx-data-shared-prod
    • fenix_derived/new_profile_activation_clients_v1
    • firefox_ios_derived/new_profile_activation_clients_v1
    • focus_android_derived/new_profile_activation_clients_v1
    • klar_android_derived/new_profile_activation_clients_v1

5 files changed

+5
-10
lines changed

sql_generators/mobile_kpi_support_metrics/templates/new_profile_activation_clients.query.sql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ WITH new_profiles AS (
99
city,
1010
geo_subdivision,
1111
locale,
12-
isp,
1312
os,
1413
os_version,
1514
device_model,
@@ -64,7 +63,7 @@ SELECT
6463
city,
6564
geo_subdivision,
6665
locale,
67-
isp,
66+
CAST(NULL AS STRING) AS isp,
6867
os,
6968
os_version,
7069
device_model,

tests/sql_generators/mobile_kpi_support_metrics/expected/moz-fx-data-shared-prod/fenix_derived/new_profile_activation_clients_v1/query.sql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ WITH new_profiles AS (
99
city,
1010
geo_subdivision,
1111
locale,
12-
isp,
1312
os,
1413
os_version,
1514
device_model,
@@ -78,7 +77,7 @@ SELECT
7877
city,
7978
geo_subdivision,
8079
locale,
81-
isp,
80+
CAST(NULL AS STRING) AS isp,
8281
os,
8382
os_version,
8483
device_model,

tests/sql_generators/mobile_kpi_support_metrics/expected/moz-fx-data-shared-prod/firefox_ios_derived/new_profile_activation_clients_v1/query.sql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ WITH new_profiles AS (
99
city,
1010
geo_subdivision,
1111
locale,
12-
isp,
1312
os,
1413
os_version,
1514
device_model,
@@ -68,7 +67,7 @@ SELECT
6867
city,
6968
geo_subdivision,
7069
locale,
71-
isp,
70+
CAST(NULL AS STRING) AS isp,
7271
os,
7372
os_version,
7473
device_model,

tests/sql_generators/mobile_kpi_support_metrics/expected/moz-fx-data-shared-prod/focus_android_derived/new_profile_activation_clients_v1/query.sql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ WITH new_profiles AS (
99
city,
1010
geo_subdivision,
1111
locale,
12-
isp,
1312
os,
1413
os_version,
1514
device_model,
@@ -62,7 +61,7 @@ SELECT
6261
city,
6362
geo_subdivision,
6463
locale,
65-
isp,
64+
CAST(NULL AS STRING) AS isp,
6665
os,
6766
os_version,
6867
device_model,

tests/sql_generators/mobile_kpi_support_metrics/expected/moz-fx-data-shared-prod/klar_android_derived/new_profile_activation_clients_v1/query.sql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ WITH new_profiles AS (
99
city,
1010
geo_subdivision,
1111
locale,
12-
isp,
1312
os,
1413
os_version,
1514
device_model,
@@ -62,7 +61,7 @@ SELECT
6261
city,
6362
geo_subdivision,
6463
locale,
65-
isp,
64+
CAST(NULL AS STRING) AS isp,
6665
os,
6766
os_version,
6867
device_model,

0 commit comments

Comments
 (0)