Add output_dir parameter for stable_tables_monitoring generator (#8570)

Author: scholtzan

sql_generators/stable_tables_monitoring/__init__.py

@@ -9,6 +9,13 @@
 
 
 @click.command()
+@click.option(
+    "--output-dir",
+    "--output_dir",
+    help="Output directory generated SQL is written to",
+    type=click.Path(file_okay=False),
+    default="sql",
+)
 @click.option(
     "--target-project",
     "--target_project",
@@ -22,6 +29,6 @@
     help="Monitoring enabled true or false",
     default=True,
 )
-def generate(target_project, enable_monitoring, **kwargs):
+def generate(target_project, output_dir, enable_monitoring, **kwargs):
     """Call generate_stable_table_bigconfig_files function."""
-    generate_stable_table_bigconfig_files(target_project, enable_monitoring)
+    generate_stable_table_bigconfig_files(target_project, output_dir, enable_monitoring)

sql_generators/stable_tables_monitoring/stable_tables_monitoring.py

@@ -20,25 +20,23 @@ def parse_config_name(config):
     return config, "v1"
 
 
-def generate_stable_table_bigconfig_files(target_project, enable_monitoring):
+def generate_stable_table_bigconfig_files(target_project, output_dir, enable_monitoring):
     """Generate the metadata and bigconfig files and write to correct directories."""
-    THIS_PATH = Path(__file__).parent
-    TEMPLATES_DIR = THIS_PATH / "templates"
-    SQL_BASE_DIR = THIS_PATH.parent.parent / "sql" / target_project
+    templates_dir = Path(__file__).parent / "templates"
+    sql_base_dir = Path(output_dir) / target_project
 
-    BIGEYE_COLLECTION = "Operational Checks"
-    BIGEYE_SLACK_CHANNEL = "#de-bigeye-triage"
+    bigeye_collection = "Operational Checks"
+    bigeye_slack_channel = "#de-bigeye-triage"
 
-    env = Environment(loader=FileSystemLoader(str(TEMPLATES_DIR)))
+    env = Environment(loader=FileSystemLoader(str(templates_dir)))
     bigconfig_template = env.get_template("bigconfig.yml.jinja")
     metadata_template = env.get_template("metadata.yaml.jinja")
 
     stable_table_bigconfigs = ConfigLoader.get("monitoring", "stable_tables_monitoring")
 
     # Create directory for each dataset
     for dataset_name, table_names in stable_table_bigconfigs.items():
-
-        target_dir = SQL_BASE_DIR / dataset_name
+        target_dir = sql_base_dir / dataset_name
         target_dir.mkdir(parents=True, exist_ok=True)
 
         # Create directory for each table each with a metadata.yaml and bigconfig.yml file
@@ -50,12 +48,12 @@ def generate_stable_table_bigconfig_files(target_project, enable_monitoring):
                 dataset=dataset_name,
                 name=name_part,
                 version=version_part,
-                bigeye_collection=BIGEYE_COLLECTION,
-                bigeye_notification_slack_channel=BIGEYE_SLACK_CHANNEL,
+                bigeye_collection=bigeye_collection,
+                bigeye_notification_slack_channel=bigeye_slack_channel,
             )
 
             metadata_rendered = metadata_template.render(
-                bigeye_collection=BIGEYE_COLLECTION,
+                bigeye_collection=bigeye_collection,
                 enable_monitoring=enable_monitoring,
                 name=name_part,
             )