chore(metadata-completeness): Add a default metadata.yaml file for views (#8373)

* chore(metadata-completeness): Add a default metadata.yaml file for views

* Update tests to expect view metadata.yaml

* Update formatting

* Remove bigquery: null from view metadata.yaml

Author: kwindau

bigquery_etl/cli/query.py

@@ -217,6 +217,18 @@ def create(ctx, name, sql_dir, project_id, owner, dag, no_schedule):
             + "\n"
         )
 
+        safe_owner = owner.lower().split("@")[0]
+
+        view_metadata_file = view_path / "metadata.yaml"
+        view_metadata = Metadata(
+            friendly_name=string.capwords(name.replace("_", " ")),
+            description="Please provide a description for the query",
+            owners=[owner],
+            labels={"owner": safe_owner},
+        )
+
+        view_metadata.write(view_metadata_file)
+
     # create query.sql file
     query_file = derived_path / "query.sql"
     query_file.write_text(

bigquery_etl/metadata/parse_metadata.py

@@ -428,6 +428,9 @@ def write(self, file):
         if not metadata_dict["monitoring"]:
             del metadata_dict["monitoring"]
 
+        if metadata_dict["bigquery"] is None:
+            del metadata_dict["bigquery"]
+
         file.write_text(
             yaml.dump(
                 converter.unstructure(metadata_dict),

tests/cli/test_cli_query.py

@@ -151,9 +151,9 @@ def test_create_derived_query_with_view(self, runner):
                 "dataset_metadata.yaml",
                 "test_query",
             ]
-            assert os.listdir("sql/moz-fx-data-shared-prod/test/test_query") == [
-                "view.sql"
-            ]
+            assert sorted(
+                os.listdir("sql/moz-fx-data-shared-prod/test/test_query")
+            ) == ["metadata.yaml", "view.sql"]
 
     def test_create_derived_query_with_existing_view(self, runner):
         with runner.isolated_filesystem():
@@ -205,9 +205,9 @@ def test_create_query_as_derived(self, runner):
                 "dataset_metadata.yaml",
                 "test_query",
             ]
-            assert os.listdir("sql/moz-fx-data-shared-prod/test/test_query") == [
-                "view.sql"
-            ]
+            assert sorted(
+                os.listdir("sql/moz-fx-data-shared-prod/test/test_query")
+            ) == ["metadata.yaml", "view.sql"]
 
     def test_schedule_invalid_path(self, runner):
         with runner.isolated_filesystem():