fix split issues in ci (#942)

Author: ben-c-at-moz

.github/workflows/check-beta-functional.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Check if the run is reportable
         id: reportable
         env:
-          TESTRAIL_FUNCTIONAL_SPLIT: 1
+          STARFOX_SPLIT: functional1
           TESTRAIL_REPORT: true
           TESTRAIL_BASE_URL: ${{ secrets.TESTRAIL_BASE_URL }}
           TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }}

.github/workflows/check-beta.yml

@@ -27,6 +27,7 @@ jobs:
           TESTRAIL_BASE_URL: ${{ secrets.TESTRAIL_BASE_URL }}
           TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }}
           TESTRAIL_USERNAME: ${{ secrets.TESTRAIL_USERNAME }}
+          STARFOX_SPLIT: smoke
         run: |
           pip3 install 'pipenv==2023.11.15';
           pipenv install

.github/workflows/check-devedition.yml

@@ -25,6 +25,7 @@ jobs:
           TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }}
           TESTRAIL_USERNAME: ${{ secrets.TESTRAIL_USERNAME }}
           FX_CHANNEL: "devedition"
+          STARFOX_SPLIT: smoke
         run: |
           pip3 install 'pipenv==2023.11.15';
           pipenv install

manifests/key.yaml

@@ -36,14 +36,14 @@ address_bar_and_search:
     result: pass
     splits:
     - functional1
-  test_copied_url_contains_https:
+  test_clipboard_pref_flip:
     result: pass
     splits:
     - functional1
-  test_clipboard_pref_flip:
+  test_copied_url_contains_https:
     result: pass
     splits:
-      - functional1
+    - functional1
   test_ctrl_enter_completes_link_and_can_refresh:
     result: pass
     splits:

modules/testrail_integration.py

@@ -146,7 +146,9 @@ def get_plan_title(version_str: str, channel: str) -> str:
             .replace("{minor}", minor)
             .replace("{beta}", "rc")
         )
-    if os.environ.get("STARFOX_SPLIT").startswith("functional"):
+    if os.environ.get("STARFOX_SPLIT") and os.environ.get("STARFOX_SPLIT").startswith(
+        "functional"
+    ):
         functional_split = os.environ["STARFOX_SPLIT"].split("functional")[-1]
         plan_title = f"{plan_title} - Functional (Split {functional_split})"
     return plan_title