Ben/recategorize tests (#940)

* reduce smoke set; run smoke on automanual flow

* close security issue in CI installer links

* update precommit

* switch headed test for smoke

* default engine dropdown not visible on first page of prefs

* minor fixes

* update key

* update key

* update key

Author: ben-c-at-moz

.github/workflows/l10n.yml

@@ -207,8 +207,10 @@ jobs:
         shell: pwsh
       - name: Download Executable
         if: ${{ inputs.win_installer_link }}
+        env:
+          WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }}
         run: |
-          Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe"
+          Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe"
           New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force
         shell: pwsh
       - name: Install Beta

.github/workflows/main.yml

@@ -99,9 +99,11 @@ jobs:
         shell: pwsh
       - name: Download Executable
         if: ${{ inputs.win_installer_link }}
+        env:
+          WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }}
         run: |
-          echo "STARFOX_SPLIT=ci-extended" | Out-File -FilePath .env -Encoding utf8 -Append -Force
-          Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe"
+          echo "STARFOX_SPLIT=smoke" | Out-File -FilePath .env -Encoding utf8 -Append -Force
+          Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe"
           New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force
         shell: pwsh
       - name: Install Beta
@@ -179,7 +181,7 @@ jobs:
         if: ${{ inputs.mac_installer_link }}
         run: |
           echo "MANUAL='true'" >> "$GITHUB_ENV";
-          echo "STARFOX_SPLIT=ci-extended" >> .env
+          echo "STARFOX_SPLIT=smoke" >> .env
           echo "Running smoke tests on supplied executable";
       - name: Install dependencies
         run: |
@@ -243,7 +245,7 @@ jobs:
           MANUAL_DOWNLOAD_LINK: ${{ inputs.linux_tarball_link }}
         run: |
           echo "MANUAL='true'" >> "$GITHUB_ENV";
-          echo "STARFOX_SPLIT=ci-extended" >> "$GITHUB_ENV"
+          echo "STARFOX_SPLIT=smoke" >> "$GITHUB_ENV"
           echo "Running smoke tests on supplied executable";
           sudo apt install gnome-screenshot
           uname -m;

choose_ci_set.py

@@ -214,8 +214,7 @@ def dedupe(run_list: list) -> list:
             fh.write("\n".join(ci_paths))
         sys.exit(0)
 
-    if len(run_list) < MIN_RUN_SIZE:
-        run_list.extend(ci_paths)
+    run_list.extend(ci_paths)
 
     # Dedupe just in case
     if SLASH == "\\":