Skip to content

Commit e7a0867

Browse files
authored
Merge pull request #12 from hikaruworld/fix/joda_convert_java_date
fix gitbucket 4.19
2 parents 2152727 + 3027faf commit e7a0867

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

build.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ lazy val root = (project in file(".")).enablePlugins(SbtTwirl)
77
organization := Organization
88
name := Name
99
version := Version
10-
scalaVersion := "2.12.1"
10+
scalaVersion := "2.12.4"
1111

1212
resolvers ++= Seq(
1313
Resolver.jcenterRepo
1414
)
1515

1616
libraryDependencies ++= Seq(
17-
"io.github.gitbucket" %% "gitbucket" % "4.11.0" % "provided",
17+
"io.github.gitbucket" %% "gitbucket" % "4.19.0" % "provided",
1818
"com.typesafe.play" %% "twirl-compiler" % "1.3.0" % "provided",
1919
"javax.servlet" % "javax.servlet-api" % "3.1.0" % "provided"
2020
)

src/main/scala/mrkm4ntr/gitbucket/network/controller/NetworkController.scala

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import java.net.URI
44
import java.nio.file._
55
import java.util
66
import java.util.Date
7+
import java.time._
8+
import java.time.temporal.ChronoUnit
79

810
import gitbucket.core.controller.{Context, ControllerBase}
911
import gitbucket.core.service.{AccountService, RepositoryService, RequestCache}
@@ -14,8 +16,8 @@ import mrkm4ntr.gitbucket.html
1416
import org.eclipse.jgit.api.Git
1517
import org.eclipse.jgit.revplot.{PlotCommit, PlotCommitList, PlotLane, PlotWalk}
1618
import org.eclipse.jgit.revwalk.RevSort
17-
import org.joda.time._
1819

20+
import org.json4s.jackson.Serialization
1921
import scala.annotation.tailrec
2022
import scala.collection.JavaConverters._
2123

@@ -71,7 +73,7 @@ trait NetworkControllerBase extends ControllerBase {
7173
val revWalk = new PlotWalk(repo)
7274
revWalk.sort(RevSort.COMMIT_TIME_DESC)
7375
try {
74-
if(allBranches != None) {
76+
if(allBranches != None) {
7577
revWalk.markStart(repository.branchList.map(repo.resolve(_)).map(revWalk.parseCommit(_)).asJava)
7678
} else {
7779
revWalk.markStart(revWalk.parseCommit(repo.resolve(currentBranch)))
@@ -80,7 +82,7 @@ trait NetworkControllerBase extends ControllerBase {
8082
plotCommitList.source(revWalk)
8183
plotCommitList.fillTo(count)
8284
val result = traverse(plotCommitList.asScala.zipWithIndex.toList, None, 0, Nil)
83-
Data(result._1, result._2.reverse, repository.branchList, currentBranch, repository.repository.defaultBranch, allBranches)
85+
Serialization.write(Data(result._1, result._2.reverse, repository.branchList, currentBranch, repository.repository.defaultBranch, allBranches))(jsonFormats)
8486
} finally {
8587
revWalk.dispose()
8688
}
@@ -89,26 +91,22 @@ trait NetworkControllerBase extends ControllerBase {
8991
}
9092

9193
def getDateMarker(date1: Date, date2: Option[Date]): (Option[Int], Option[Int]) = date2.map { date2 =>
92-
val dateTime1 = new DateTime(date1)
93-
val dateTime2 = new DateTime(date2)
94-
val day = if (Days.daysBetween(
95-
new LocalDate(dateTime1.getYear, dateTime1.getMonthOfYear, dateTime1.getDayOfMonth),
96-
new LocalDate(dateTime2.getYear, dateTime2.getMonthOfYear, dateTime2.getDayOfMonth)).getDays > 0) {
94+
val dateTime1 = LocalDateTime.ofInstant(date1.toInstant(), ZoneId.systemDefault())
95+
val dateTime2 = LocalDateTime.ofInstant(date2.toInstant(), ZoneId.systemDefault())
96+
val day = if (ChronoUnit.DAYS.between(dateTime1, dateTime2) > 0) {
9797
Some(dateTime1.getDayOfMonth)
9898
} else {
9999
None
100100
}
101-
val month = if (Months.monthsBetween(
102-
new YearMonth(dateTime1.getYear, dateTime1.getMonthOfYear),
103-
new YearMonth(dateTime2.getYear, dateTime2.getMonthOfYear)).getMonths > 0) {
104-
Some(dateTime1.getMonthOfYear)
101+
val month = if (ChronoUnit.MONTHS.between(dateTime1, dateTime2) > 0) {
102+
Some(dateTime1.getMonthValue)
105103
} else {
106104
None
107105
}
108106
(month, day)
109107
} getOrElse {
110-
val dateTime1 = new DateTime(date1)
111-
(Some(dateTime1.getMonthOfYear), Some(dateTime1.getDayOfMonth))
108+
val dateTime1 = LocalDateTime.ofInstant(date1.toInstant(), ZoneId.systemDefault())
109+
(Some(dateTime1.getMonthValue), Some(dateTime1.getDayOfMonth))
112110
}
113111

114112
def getAvatarUrl(mailAddress: String, size: Int)(implicit context: Context): String = {

0 commit comments

Comments
 (0)