remove implicit disk source

Author: conradludgate

neonvm-runner/cmd/main.go

@@ -248,7 +248,6 @@ func run(logger *zap.Logger) error {
 					Secret:    nil,
 					Projected: nil,
 					Tmpfs:     nil,
-					Implicit:  nil,
 				},
 			})
 		}
@@ -732,13 +731,7 @@ func monitorFiles(ctx context.Context, logger *zap.Logger, wg *sync.WaitGroup, v
 		if disk.Watch != nil && *disk.Watch {
 			// secrets/configmaps are mounted using the atomicwriter utility,
 			// which loads the directory into `..data`.
-			dataDir := fmt.Sprintf("%s/..data", disk.MountPath)
-
-			// when we mount the disk ourselves, it goes into /vm/mounts.
-			// when the volumemount is implicit, it exists where it exists.
-			if disk.DiskSource.Implicit == nil {
-				dataDir = fmt.Sprintf("/vm/mounts%s", dataDir)
-			}
+			dataDir := fmt.Sprintf("/vm/mounts%s/..data", disk.MountPath)
 
 			secrets[dataDir] = disk.MountPath
 			secretsOrd = append(secretsOrd, dataDir)

neonvm/apis/neonvm/v1/virtualmachine_types.go

@@ -564,10 +564,6 @@ type DiskSource struct {
 	// TmpfsDisk represents a tmpfs.
 	// +optional
 	Tmpfs *TmpfsDiskSource `json:"tmpfs,omitempty"`
-	// Implicit represents an implicit volume that will be automatically mounted.
-	// Suitable for `aws-iam-token` or `azure-identity-token`, among other things.
-	// +optional
-	Implicit *ImplicitDiskSource `json:"implicit,omitempty"`
 }
 
 type ImplicitDiskSource struct{}

neonvm/apis/neonvm/v1/zz_generated.deepcopy.go

@@ -1099,11 +1099,6 @@ spec:
                       required:
                       - size
                       type: object
-                    implicit:
-                      description: |-
-                        Implicit represents an implicit volume that will be automatically mounted.
-                        Suitable for `aws-iam-token` or `azure-identity-token`, among other things.
-                      type: object
                     mountPath:
                       description: |-
                         Path within the virtual machine at which the disk should be mounted.  Must