Skip to content

Conversation

@jotare
Copy link
Contributor

@jotare jotare commented Dec 4, 2025

Description

Replace RAG strategies with /augment calls while implementing /augment:

  • Full resource
  • Field extension
  • Neighbour paragraphs
  • Hierarchy
  • Metadata extension
  • Conversational
  • Default (for conversations)
  • Graph

How was this PR tested?

Describe how you tested this PR.

@jotare jotare marked this pull request as draft December 4, 2025 16:02
@jotare jotare requested a review from a team December 4, 2025 16:02
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 36.74797% with 389 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.82%. Comparing base (c89e7da) to head (8dee337).

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/search/search/chat/prompt.py 4.34% 132 Missing ⚠️
nucliadb/src/nucliadb/search/api/v1/augment.py 6.38% 88 Missing ⚠️
...ucliadb/src/nucliadb/search/augmentor/augmentor.py 14.03% 49 Missing ⚠️
nucliadb/src/nucliadb/search/search/chat/rpc.py 37.03% 34 Missing ⚠️
nucliadb/src/nucliadb/search/augmentor/fields.py 35.48% 20 Missing ⚠️
nucliadb_models/src/nucliadb_models/augment.py 78.08% 16 Missing ⚠️
nucliadb/src/nucliadb/models/internal/augment.py 87.17% 15 Missing ⚠️
.../src/nucliadb/search/search/hydrator/paragraphs.py 0.00% 14 Missing ⚠️
nucliadb/src/nucliadb/search/api/v1/retrieve.py 30.00% 7 Missing ⚠️
nucliadb/src/nucliadb/search/search/chat/query.py 44.44% 5 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   85.56%   84.82%   -0.74%     
==========================================
  Files         548      549       +1     
  Lines       45088    45362     +274     
  Branches    12658    12658              
==========================================
- Hits        38578    38479      -99     
- Misses       5893     6265     +372     
- Partials      617      618       +1     
Flag Coverage Δ
nidx 79.29% <ø> (-0.01%) ⬇️
nucliadb-ingest 44.72% <36.74%> (-0.12%) ⬇️
nucliadb-reader 44.85% <36.74%> (-0.12%) ⬇️
nucliadb-standalone 47.14% <36.74%> (-0.13%) ⬇️
nucliadb-train 45.84% <36.74%> (-0.12%) ⬇️
nucliadb-writer 47.97% <36.74%> (-0.13%) ⬇️
nucliadb_dataset 73.11% <5.00%> (-1.31%) ⬇️
nucliadb_models 76.48% <5.00%> (-1.92%) ⬇️
nucliadb_utils 81.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare
Copy link
Contributor Author

jotare commented Dec 5, 2025

[sc-13240]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants