Skip to content

Commit 439f0cd

Browse files
committed
Update MMCV and CI configuration
- Downgrade MMCV find-links to torch2.3.0 in pyproject.toml - Remove Python version restriction for MMCV test in CI workflow - Remove Python version skip marker in MMDetection model test
1 parent de17485 commit 439f0cd

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ jobs:
7272
# coco analyse
7373
sahi coco analyse --dataset_json_path tests/data/coco_evaluate/dataset.json --result_json_path tests/data/coco_evaluate/result.json --out_dir tests/data/coco_evaluate/
7474
- name: Test SAHI CLI with MMCV
75-
if: matrix.python-version == '3.8' || matrix.python-version == '3.9' || matrix.python-version == '3.10'
7675
run: |
7776
source .venv/bin/activate
7877
set -e

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ sahi = "sahi.cli:app"
4141

4242
[tool.uv]
4343
find-links = [
44-
"https://download.openmmlab.com/mmcv/dist/cpu/torch2.3.1/index.html"
44+
"https://download.openmmlab.com/mmcv/dist/cpu/torch2.3.0/index.html"
4545
]
4646
default-groups = ["dev", "ci"]
4747

tests/test_mmdetectionmodel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from sahi.utils.cv import read_image
1212
from sahi.utils.mmdet import MmdetTestConstants, download_mmdet_cascade_mask_rcnn_model, download_mmdet_yolox_tiny_model
1313

14-
pytestmark = pytest.mark.skipif(sys.version_info[:2] > (3, 10), reason="Requires Python 3.10 or lower")
14+
#pytestmark = pytest.mark.skipif(sys.version_info[:2] > (3, 10), reason="Requires Python 3.10 or lower")
1515
MODEL_DEVICE = "cpu"
1616
CONFIDENCE_THRESHOLD = 0.5
1717
IMAGE_SIZE = 320

0 commit comments

Comments
 (0)