Skip to content

Commit 0c2d2a3

Browse files
committed
revert aws test
1 parent f32b31e commit 0c2d2a3

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientCoreTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,10 @@ public abstract class AbstractAws2ClientCoreTest {
9898

9999
protected abstract ClientOverrideConfiguration.Builder createOverrideConfigurationBuilder();
100100

101-
protected boolean isSqsAttributeInjectionEnabled() {
101+
protected static boolean isSqsAttributeInjectionEnabled() {
102102
// See io.opentelemetry.instrumentation.awssdk.v2_2.autoconfigure.TracingExecutionInterceptor
103103
return ConfigPropertiesUtil.getBoolean(
104-
getTesting().getOpenTelemetry(), "aws_sdk", "experimental_use_propagator_for_messaging")
105-
.orElse(false);
104+
"otel.instrumentation.aws-sdk.experimental-use-propagator-for-messaging", false);
106105
}
107106

108107
protected void configureSdkClient(SdkClientBuilder<?, ?> builder) {

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientRecordHttpErrorTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,7 @@ private static void cleanResponses() {
126126
public boolean isRecordIndividualHttpErrorEnabled() {
127127
// See io.opentelemetry.instrumentation.awssdk.v2_2.autoconfigure.TracingExecutionInterceptor
128128
return ConfigPropertiesUtil.getBoolean(
129-
getTesting().getOpenTelemetry(), "aws_sdk", "experimental_record_individual_http_error")
130-
.orElse(false);
129+
"otel.instrumentation.aws-sdk.experimental-record-individual-http-error", false);
131130
}
132131

133132
@SuppressWarnings("deprecation") // using deprecated semconv

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public abstract class AbstractAws2ClientTest extends AbstractAws2ClientCoreTest
273273
+ " </ResponseMetadata>"
274274
+ "</CreateTopicResponse>";
275275

276-
private void assumeSupportedConfig(String operation) {
276+
private static void assumeSupportedConfig(String operation) {
277277
Assumptions.assumeFalse(
278278
operation.equals("SendMessage") && isSqsAttributeInjectionEnabled(),
279279
"Cannot check Sqs.SendMessage here due to hard-coded MD5.");

instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsBaseTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,7 @@ protected void configureSdkClient(SqsAsyncClientBuilder builder) throws URISynta
132132
protected boolean isSqsAttributeInjectionEnabled() {
133133
// See io.opentelemetry.instrumentation.awssdk.v2_2.autoconfigure.TracingExecutionInterceptor
134134
return ConfigPropertiesUtil.getBoolean(
135-
getTesting().getOpenTelemetry(), "aws_sdk", "experimental_use_propagator_for_messaging")
136-
.orElse(false);
135+
"otel.instrumentation.aws-sdk.experimental-use-propagator-for-messaging", false);
137136
}
138137

139138
@BeforeAll

0 commit comments

Comments
 (0)