Commit 9b4c12a
committed
Update GraphQL Recommended vs Opt-In requirements
The `graphql.document` is user-inputted, often containing sensitive information, potentially unbounded in length and high-cardinality in the same way as the existing `graphql.operation.name` is warned.
For this reason, `graphql.document` is a liability to have listed as `Recommended` without serious infrastructure considerations and needs, making `Opt-In` a better option. In our customer adoption of OpenTelemetry, we've found our GraphQL customers following this configuration/instruction while not understanding the implications.
In most cases, the lesser liability of `graphql.operation.name` (The actual operation name) is sufficient, as in many GraphQL deployments there is generally a link between the two which can be correlated out of band. The operation name isn't without its risk, but it's more likely to be dozens of *bytes* of a limited character set rather than dozens, hundreds or potentially thousands of *kilobytes*. In that regard, I've left `graphq.operation.name` as `Recommended`, though the argument could easily be made that it should also be `Opt-In`.1 parent cfbac6a commit 9b4c12a
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments