Skip to content

Commit b5d47c9

Browse files
thompson-tomotrask
thompson-tomo
and
trask
authored
explicit json rpc span definitions #2228 (#2503)
Co-authored-by: Trask Stalnaker <[email protected]>
1 parent ea48396 commit b5d47c9

File tree

11 files changed

+303
-58
lines changed

11 files changed

+303
-58
lines changed

‎.chloggen/rpc-json_rpc_span_def.yaml‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Use this changelog template to create an entry for release notes.
2+
#
3+
# If your change doesn't affect end users you should instead start
4+
# your pull request title with [chore] or use the "Skip Changelog" label.
5+
6+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
7+
change_type: enhancement
8+
9+
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
10+
component: rpc
11+
12+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
13+
note: JSON-RPC now has its own span definition.
14+
15+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
16+
# The values here must be integers.
17+
issues: [2228]
18+
19+
# (Optional) One or more lines of additional information to render under the primary note.
20+
# These lines will be padded with 2 spaces and then inserted directly into the document.
21+
# Use pipe (|) for multiline entries.
22+
subtext:

‎docs/cloud-providers/aws-sdk.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ interesting conventions are found.
6464
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
6565
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
6666
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
67+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
6768
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
6869

6970
<!-- markdownlint-restore -->

‎docs/database/dynamodb.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ This span represents a `DynamoDB.BatchGetItem` call.
8080
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
8181
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
8282
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
83+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
8384
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
8485

8586
<!-- markdownlint-restore -->
@@ -135,6 +136,7 @@ This span represents a `DynamoDB.BatchWriteItem` call.
135136
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
136137
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
137138
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
139+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
138140
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
139141

140142
<!-- markdownlint-restore -->
@@ -194,6 +196,7 @@ This span represents a `DynamoDB.CreateTable` call.
194196
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
195197
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
196198
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
199+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
197200
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
198201

199202
<!-- markdownlint-restore -->
@@ -249,6 +252,7 @@ This span represents a `DynamoDB.DeleteItem` call.
249252
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
250253
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
251254
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
255+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
252256
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
253257

254258
<!-- markdownlint-restore -->
@@ -302,6 +306,7 @@ This span represents a `DynamoDB.DeleteTable` call.
302306
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
303307
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
304308
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
309+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
305310
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
306311

307312
<!-- markdownlint-restore -->
@@ -355,6 +360,7 @@ This span represents a `DynamoDB.DescribeTable` call.
355360
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
356361
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
357362
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
363+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
358364
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
359365

360366
<!-- markdownlint-restore -->
@@ -411,6 +417,7 @@ This span represents a `DynamoDB.GetItem` call.
411417
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
412418
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
413419
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
420+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
414421
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
415422

416423
<!-- markdownlint-restore -->
@@ -466,6 +473,7 @@ This span represents a `DynamoDB.ListTables` call.
466473
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
467474
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
468475
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
476+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
469477
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
470478

471479
<!-- markdownlint-restore -->
@@ -521,6 +529,7 @@ This span represents a `DynamoDB.PutItem` call.
521529
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
522530
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
523531
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
532+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
524533
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
525534

526535
<!-- markdownlint-restore -->
@@ -582,6 +591,7 @@ This span represents a `DynamoDB.Query` call.
582591
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
583592
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
584593
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
594+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
585595
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
586596

587597
<!-- markdownlint-restore -->
@@ -646,6 +656,7 @@ This span represents a `DynamoDB.Scan` call.
646656
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
647657
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
648658
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
659+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
649660
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
650661

651662
<!-- markdownlint-restore -->
@@ -701,6 +712,7 @@ This span represents a `DynamoDB.UpdateItem` call.
701712
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
702713
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
703714
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
715+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
704716
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
705717

706718
<!-- markdownlint-restore -->
@@ -759,6 +771,7 @@ This span represents a `DynamoDB.UpdateTable` call.
759771
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
760772
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
761773
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
774+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
762775
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
763776

764777
<!-- markdownlint-restore -->

‎docs/object-stores/s3.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ This applies in particular to the following operations:
9999
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
100100
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
101101
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
102+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
102103
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
103104

104105
<!-- markdownlint-restore -->

‎docs/registry/attributes/rpc.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ the `rpc.grpc.response.metadata.my-custom-key` attribute with value `["attribute
127127
| `dotnet_wcf` | .NET WCF | ![Development](https://img.shields.io/badge/-development-blue) |
128128
| `grpc` | gRPC | ![Development](https://img.shields.io/badge/-development-blue) |
129129
| `java_rmi` | Java RMI | ![Development](https://img.shields.io/badge/-development-blue) |
130+
| `jsonrpc` | JSON-RPC | ![Development](https://img.shields.io/badge/-development-blue) |
130131
| `onc_rpc` | [ONC RPC (Sun RPC)](https://datatracker.ietf.org/doc/html/rfc5531) | ![Development](https://img.shields.io/badge/-development-blue) |
131132

132133
## Deprecated RPC Attributes

0 commit comments

Comments
 (0)