Skip to content

Commit 7e45071

Browse files
authored
Merge pull request #20 from EmanuelCR03/main
Fix Docker Compose execution for new docker group members
2 parents 0a77ea7 + e1ab028 commit 7e45071

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

install.sh

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ install_docker(){
107107

108108
# Apply group change in current shell
109109
newgrp docker <<EONG
110-
echo "✅ Docker is installed and group membership applied in this session."
110+
echo "✅ Docker is installed and group membership applied."
111+
echo "⚠️ To use Docker without 'sudo', you need to log out and log back in or restart your session."
112+
read -p "Press Enter to continue..."
111113
EONG
112114
fi
113115
}
@@ -500,7 +502,12 @@ if [ "$answer" = "n" ]; then
500502
exit 0
501503
else
502504
echo "🐳 Starting Docker containers..."
503-
docker compose up -d
505+
if [[ $(uname) == "Darwin" ]]; then
506+
docker compose up -d
507+
else
508+
sg docker -c "docker compose up -d"
509+
fi
510+
504511
# Check if port is listening
505512
echo "Waiting for server to be healthy, it might take a few minutes while we initialize the database..."
506513

@@ -514,8 +521,13 @@ else
514521
# Tail logs of the server until it's ready
515522
# Start logs with timeout (will automatically stop after N seconds)
516523
#docker compose logs -f fineract-server &
517-
docker compose logs -f fineract-server &
518-
log_pid=$!
524+
if [[ $(uname) == "Darwin" ]]; then
525+
docker compose logs -f fineract-server &
526+
log_pid=$!
527+
else
528+
sg docker -c "docker compose logs -f fineract-server" &
529+
log_pid=$!
530+
fi
519531

520532
while [ "$(docker inspect --format='{{.State.Health.Status}}' "$container_id" 2>/dev/null)" != "healthy" ]; do
521533
sleep 1

mariadb/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ services:
4242
volumes:
4343
- ./fineract-server/data:/data
4444
healthcheck:
45-
test: ["CMD", 'sh', '-c', 'echo -e "Checking for the availability of Fineract server deployment"; while ! nc -z "fineract-server" ${FINERACT_PORT:-3000}; do sleep 1; printf "-"; done; echo -e " >> Fineract server has started";' ]
45+
test: ["CMD", 'sh', '-c', 'echo -e "Checking for the availability of Fineract server deployment"; while ! nc -z "fineract-server" 8080; do sleep 1; printf "-"; done; echo -e " >> Fineract server has started";' ]
4646
timeout: 10s
4747
retries: 10
4848
ports:

postgresql/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ services:
3838
volumes:
3939
- ./fineract-server/data:/data
4040
healthcheck:
41-
test: ["CMD", 'sh', '-c', 'echo -e "Checking for the availability of Fineract server deployment"; while ! nc -z "fineract-server" ${FINERACT_PORT:-3000}; do sleep 1; printf "-"; done; echo -e " >> Fineract server has started";' ]
41+
test: ["CMD", 'sh', '-c', 'echo -e "Checking for the availability of Fineract server deployment"; while ! nc -z "fineract-server" 8080; do sleep 1; printf "-"; done; echo -e " >> Fineract server has started";' ]
4242
timeout: 10s
4343
retries: 10
4444
ports:

0 commit comments

Comments
 (0)