Move UpgradeableUpgradeInProgress into the internal pkg

hongkailiu · hongkailiu · commit d5212c0e014c · 2025-11-19T15:52:58.000-05:00
diff --git a/pkg/cvo/upgradeable.go b/pkg/cvo/upgradeable.go
@@ -269,7 +269,7 @@ type upgradeInProgressUpgradeable struct {
 
 func (check *upgradeInProgressUpgradeable) Check() *configv1.ClusterOperatorStatusCondition {
 	cond := &configv1.ClusterOperatorStatusCondition{
-		Type:   "UpgradeableUpgradeInProgress",
+		Type:   internal.UpgradeableUpgradeInProgress,
 		Status: configv1.ConditionTrue,
 	}
 
diff --git a/pkg/internal/constants.go b/pkg/internal/constants.go
@@ -67,4 +67,7 @@ const (
 	// UpgradeableClusterVersionOverrides is False if there are overrides in the Cluster Version, and thus update to the next minor
 	// version is blocked.
 	UpgradeableClusterVersionOverrides configv1.ClusterStatusConditionType = "UpgradeableClusterVersionOverrides"
+
+	// UpgradeableUpgradeInProgress is True if an update is in progress
+	UpgradeableUpgradeInProgress configv1.ClusterStatusConditionType = "UpgradeableUpgradeInProgress"
 )

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ type upgradeInProgressUpgradeable struct {`
`269`	`269`
`270`	`270`	`func (check upgradeInProgressUpgradeable) Check() configv1.ClusterOperatorStatusCondition {`
`271`	`271`	`cond := &configv1.ClusterOperatorStatusCondition{`
`272`		`- Type: "UpgradeableUpgradeInProgress",`
	`272`	`+ Type: internal.UpgradeableUpgradeInProgress,`
`273`	`273`	`Status: configv1.ConditionTrue,`
`274`	`274`	`}`
`275`	`275`
Original file line number	Diff line number	Diff line change
`@@ -67,4 +67,7 @@ const (`
`67`	`67`	`// UpgradeableClusterVersionOverrides is False if there are overrides in the Cluster Version, and thus update to the next minor`
`68`	`68`	`// version is blocked.`
`69`	`69`	`UpgradeableClusterVersionOverrides configv1.ClusterStatusConditionType = "UpgradeableClusterVersionOverrides"`
	`70`	`+`
	`71`	`+ // UpgradeableUpgradeInProgress is True if an update is in progress`
	`72`	`+ UpgradeableUpgradeInProgress configv1.ClusterStatusConditionType = "UpgradeableUpgradeInProgress"`
`70`	`73`	`)`