Skip to content

Commit 2c63273

Browse files
committed
Set a default template (output format) and remove the alert for not having selected one.
1 parent fd307ca commit 2c63273

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

public/js/navbar.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -141,14 +141,7 @@ renderbutton.addEventListener("click", (event) => {
141141
const renderurl = "render-api";
142142

143143
const selectedformat = document.querySelector(".dropdown-item.selected");
144-
let outputFormat;
145-
if (selectedformat === null) {
146-
console.log(typeof selectedformat);
147-
alert("No output format selected. Defaulting to 'classic' format.");
148-
outputFormat = "classic";
149-
} else {
150-
outputFormat = selectedformat.id;
151-
}
144+
const outputFormat = selectedformat?.id ?? 'default';
152145
let formData = new FormData();
153146
formData.set("showComments", 1);
154147
formData.set(
@@ -231,13 +224,7 @@ function insertListener() {
231224
const selectedformat = document.querySelector(
232225
".dropdown-item.selected"
233226
);
234-
let outputFormat;
235-
if (selectedformat === null) {
236-
alert("No output format selected. Defaulting to 'classic' format.");
237-
outputFormat = "classic";
238-
} else {
239-
outputFormat = selectedformat.id;
240-
}
227+
const outputFormat = selectedformat?.id ?? 'default';
241228
formData.set("isInstructor", 1);
242229
formData.set("includeTags", 1);
243230
formData.set("showComments", 1);

templates/layouts/navbar.html.ep

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@
1111
<body>
1212
<div class="topnav" id="myTopnav">
1313
<div class="dropdown" id="template-select-dropdown">
14-
<button class="dropbtn" id="template-select">Template
15-
<i class="fa fa-caret-down"></i>
16-
</button>
14+
<button class="dropbtn" id="template-select">Default <i class="fa fa-caret-down"></i></button>
1715
<div class="dropdown-content">
1816
<a href="#" class="dropdown-item" id="static">Static <i class="fa fa-check" aria-hidden="true"></i></a>
19-
<a href="#" class="dropdown-item" id="default">Default <i class="fa fa-check" aria-hidden="true"></i></a>
17+
<a href="#" class="dropdown-item selected" id="default">Default <i class="fa fa-check" aria-hidden="true"></i></a>
2018
<a href="#" class="dropdown-item" id="debug">Debug <i class="fa fa-check" aria-hidden="true"></i></a>
2119
</div>
2220
</div>

0 commit comments

Comments
 (0)