Commit 8f8267b
Suggestions for improvement.
Inline javascript is bad form. There is already a javascript file
dedicated to the ProblemSetDetail.pm page, so put the javascript there
instead.
The return value of the Mojolicious::Plugin::TagHelpers `tag` method is
already a Mojo::ByteStream object. The issue that causes the display to
not work is that the contents of the `div` are not, since they are just
bare strings concatentated together, and so they are html escaped. So
use a Mojo::Collection that is joined by the empty string. That also
returns a Mojo::ByteStream object, and so it is not html escaped. This
is also consistent with how I have done this sort of thing elsewhere in
the code.
Also remove what appears to be an errant `warn` statement.1 parent 4375271 commit 8f8267b
File tree
2 files changed
+16
-10
lines changed- htdocs/js/ProblemSetDetail
- lib/WeBWorK/ContentGenerator/Instructor
2 files changed
+16
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
417 | 423 | | |
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
947 | 947 | | |
948 | 948 | | |
949 | 949 | | |
950 | | - | |
| 950 | + | |
951 | 951 | | |
952 | 952 | | |
953 | 953 | | |
954 | | - | |
955 | | - | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
956 | 957 | | |
957 | | - | |
958 | | - | |
959 | | - | |
960 | | - | |
961 | | - | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
962 | 962 | | |
963 | 963 | | |
964 | | - | |
965 | | - | |
| 964 | + | |
| 965 | + | |
966 | 966 | | |
967 | 967 | | |
968 | 968 | | |
| |||
0 commit comments