a bunch of cleanup.

Author: pstaabp

.eslintrc.js

@@ -47,6 +47,7 @@ module.exports = {
 		process: 'readonly'
 	},
 	rules: baseRules,
+
 	overrides: [{
 		files: ['*.ts', '*.tsx', '*.vue'],
 

.github/workflows/linter.yml

@@ -56,10 +56,6 @@ jobs:
       # Run Linter against code base #
       ################################
       - name: Super-Linter
-        # Note that this actually uses super-linter version 4.6.0 which is the desired version.
-        # See https://github.com/github/super-linter/issues/1839.
-        # It seems that version 4.6.1 has a bug with perlcritic, so we actually want 4.6.0.
-        # updated to 4.8.1  If this works, I'll edit the above lines.
         uses: github/[email protected]
 
         env:

.github/workflows/unit-tests.yml

@@ -32,7 +32,8 @@ jobs:
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         run: cover -report codecov
-              # Install node (for npm) and use it to install eslint and stylelint dependencies.
+
+      # Install node (for npm) and use it to install eslint and stylelint dependencies.
       - name: Use Node.js
         uses: actions/setup-node@v2
         with:

conf/ww3-dev.yml

@@ -0,0 +1,28 @@
+---
+secrets:
+  - 3cdf63327fcf77deaed1d200df4b9fee66af2326
+webwork3_home: /opt/webwork/webwork3
+
+# Database settings
+
+# These settings are used for running unit_tests.  You should choose a database
+# that is separate from any either production or other testing database.  The
+# sqlite one is recommended.  If you choose another full-featured DB, select a
+# database that is different than others.
+
+# For the sqlite database
+test_database_dsn: dbi:SQLite:/opt/webwork/webwork3/t/db/sample_db.sqlite
+# For mysql or mariadb
+# note: choose a database
+#test_database_dsn: dbi:mysql:dbname=webwork3_test
+
+# Database credentials for mysql or mariadb.
+# These are ignored if the 'sqlite' database is used.
+test_database_user: webworkWrite
+test_database_password: password
+
+# If ignore_permissions is set to true, all routes can be executed.
+# This should only be used in development.
+ignore_permissions: true
+
+

jest.config.js

@@ -1,27 +1,25 @@
 /* eslint-disable no-undef */
 
 /** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
-const { pathsToModuleNameMapper } = require('ts-jest/utils')
+const { pathsToModuleNameMapper } = require('ts-jest/utils');
 // In the following statement, replace `./tsconfig` with the path to your `tsconfig` file
 // which contains the path mapping (ie the `compilerOptions.paths` option):
 
-const { compilerOptions } = require('./tsconfig')
-
-
+const { compilerOptions } = require('./tsconfig');
 
 module.exports = {
 	preset: 'ts-jest',
 	testEnvironment: 'node',
 	globals: {
-		"ts-jest": {
-			"tsconfig": "tsconfig.json",
-			"diagnostics": true
+		'ts-jest': {
+			'tsconfig': 'tsconfig.json',
+			'diagnostics': true
 		}
 	},
 	// A map from regular expressions to module names that allow to stub out resources with a single module
 	// moduleNameMapper: {
 	//   '^@/(.*)$': '<rootDir>/src/$1',
 	// },
-	moduleNameMapper: pathsToModuleNameMapper(compilerOptions.paths , { prefix: '<rootDir>/' } ),
-	testRegex: "(/tests/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$",
+	moduleNameMapper: pathsToModuleNameMapper(compilerOptions.paths, { prefix: '<rootDir>/' }),
+	testRegex: '(/tests/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$',
 };

lib/DB/Schema/Result/ProblemSet.pm

@@ -100,15 +100,17 @@ __PACKAGE__->add_columns(
 		default_value => 1,
 		is_nullable   => 0
 	},
-	set_dates => {    # store dates as a JSON object
+	# store dates as a JSON object
+	set_dates => {
 		data_type          => 'text',
 		size               => 256,
 		is_nullable        => 0,
 		default_value      => '{}',
 		serializer_class   => 'JSON',
 		serializer_options => { utf8 => 1 }
 	},
-	set_params => {    # store params as a JSON object
+	# store params as a JSON object
+	set_params => {
 		data_type          => 'text',
 		size               => 256,
 		is_nullable        => 0,

lib/DB/Schema/ResultSet/Problem.pm

@@ -3,9 +3,6 @@ use strict;
 use warnings;
 use base 'DBIx::Class::ResultSet';
 
-use Carp;
-use Data::Dumper;
-
 # use List::Util qw/first/;
 
 use DB::Utils qw/getCourseInfo getSetInfo getProblemInfo/;

lib/DB/Schema/ResultSet/ProblemPool.pm

@@ -3,9 +3,6 @@ use strict;
 use warnings;
 use base 'DBIx::Class::ResultSet';
 
-use Carp;
-use Data::Dumper;
-use Scalar::Util qw/reftype/;
 use Try::Tiny;
 
 use DB::Utils qw/getCourseInfo getPoolInfo getPoolProblemInfo/;

lib/DB/Schema/ResultSet/ProblemSet.pm

@@ -5,7 +5,6 @@ use base 'DBIx::Class::ResultSet';
 
 use Carp;
 use Clone qw/clone/;
-use Data::Dumper;
 
 use DB::Utils qw/getCourseInfo getUserInfo getSetInfo updateAllFields/;
 

lib/DB/Schema/ResultSet/User.pm

@@ -11,7 +11,6 @@ use strict;
 use warnings;
 use base 'DBIx::Class::ResultSet';
 
-use Data::Dumper;
 use Array::Utils qw/array_minus/;
 use Clone qw/clone/;
 
@@ -367,8 +366,7 @@ The method returns only the information in the course_user table
 
 sub addCourseUser {
 	my ($self, $course_user_params, $as_result_set) = @_;
-	# warn "in addCourseUser";
-	# warn Dumper $course_user_params;
+
 	my $course = $self->result_source->schema->resultset("Course")->getCourse(getCourseInfo($course_user_params), 1);
 	my $user   = $self->getGlobalUser(getUserInfo($course_user_params), 1);