Skip to content

Commit fb597cf

Browse files
committed
Add the eslint space-infix-ops rule, and run npm run lint to fix the
issues it shows.
1 parent 6bb7d6f commit fb597cf

File tree

10 files changed

+14
-13
lines changed

10 files changed

+14
-13
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const baseRules = {
1919
'one-var': 'off',
2020
'no-void': 'off',
2121
'multiline-ternary': 'off',
22+
'space-infix-ops': ['error'],
2223

2324
// allow console and debugger during development only
2425
'no-console': process.env.NODE_ENV === 'development' ? 'off' : 'error',

src/components/common/DateTimeInput.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default defineComponent({
4040
},
4141
emits: ['update:modelValue'],
4242
setup (props, { emit }) {
43-
const date_string = ref(date.formatDate((props.modelValue || Date.now())*1000, 'YYYY-MM-DD HH:mm'));
43+
const date_string = ref(date.formatDate((props.modelValue || Date.now()) * 1000, 'YYYY-MM-DD HH:mm'));
4444
4545
watch(
4646
() => date_string.value,

src/components/instructor/ClasslistManagerComponents/AddUsersFromFile.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export default defineComponent({
218218
parse_error = {
219219
type: 'warn',
220220
message: `The user with username '${merged_user.username ?? ''}'`
221-
+' is already enrolled in the course.',
221+
+ ' is already enrolled in the course.',
222222
entire_row: true
223223
};
224224
} else {
@@ -238,7 +238,7 @@ export default defineComponent({
238238
if (err.field === '_all') {
239239
assign(parse_error, { entire_row: true });
240240
} else if (err.field &&
241-
(user_fields.indexOf(err.field)>=0 || course_user_fields.indexOf(err.field)>=0)) {
241+
(user_fields.indexOf(err.field) >= 0 || course_user_fields.indexOf(err.field) >= 0)) {
242242
assign(parse_error, {
243243
col: user_param_map.value[err.field],
244244
entire_row: user_param_map.value[err.field] == undefined
@@ -285,7 +285,7 @@ export default defineComponent({
285285
};
286286
d._row = index;
287287
row.forEach((v: string, i: number) => {
288-
d[`col${i+1}`] = v;
288+
d[`col${i + 1}`] = v;
289289
});
290290
users.push(d);
291291
});

src/components/instructor/ClasslistManagerComponents/AddUsersManually.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export default defineComponent({
9696
(_setting: CourseSetting) => _setting.var === 'roles'
9797
);
9898
const r = clone(all_roles?.value as Array<string>);
99-
remove(r, (v)=> v==='admin'); // don't allow to set admin level here.
99+
remove(r, (v)=> v === 'admin'); // don't allow to set admin level here.
100100
return r;
101101
}),
102102
addUser: async (close: boolean) => {

src/components/instructor/ClasslistManagerComponents/EditUsers.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export default defineComponent({
8383
(_setting: CourseSetting) => _setting.var === 'roles'
8484
);
8585
const r = clone(all_roles?.value as Array<string>);
86-
remove(r, v => v==='admin'); // don't allow to set admin level here.
86+
remove(r, v => v === 'admin'); // don't allow to set admin level here.
8787
return r;
8888
}),
8989
};

src/components/instructor/SetDetails/Quiz.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export default defineComponent({
9191
checkDates: [
9292
() => {
9393
const d = set.value.set_dates;
94-
return d.open <= d.due && d.due <=d.answer || 'The dates must be in order';
94+
return d.open <= d.due && d.due <= d.answer || 'The dates must be in order';
9595
}
9696
],
9797
quizDuration: [

src/layouts/MainLayout.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ export default defineComponent({
6666
6767
if (! current_view) { // it may be a child component
6868
current_view = views.find((view: ViewInfo) =>
69-
view.children ? view.children?.indexOf(route.name as string)> -1 : false);
69+
view.children ? view.children?.indexOf(route.name as string) > -1 : false);
7070
}
7171
7272
logger.debug(`[MainLayout/updateViews] name: ${current_view?.name || 'no name!'}`);
7373
if (current_view) {
7474
sidebars.value = current_view.sidebars;
75-
if (current_view.sidebars.length>0) {
75+
if (current_view.sidebars.length > 0) {
7676
logger.debug(`[MainLayout/updateViews] sidebar: ${current_view.sidebars.join(', ')}`);
7777
right_sidebar_open.value = true;
7878
} else {

src/store/models/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export const Model = <Bool extends string, Num extends string, Str extends strin
215215
_dictionary_field_names: Array<Dic> = dictionary_fields;
216216
_fields: F = fields;
217217

218-
constructor(params: Dictionary<generic | Dictionary<generic>>= {}) {
218+
constructor(params: Dictionary<generic | Dictionary<generic>> = {}) {
219219
// check that required fields are present
220220

221221
const common_fields = intersection(this.required_fields, Object.keys(params));

src/store/modules/session.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const getters: GetterTree<SessionState, StateInterface> & Getters = {
3636
logged_in: (state) => state.logged_in,
3737
user: (state) => state.user,
3838
full_name: (state) => {
39-
return `${state.user.first_name|| ''} ${state.user.last_name || ''}`;
39+
return `${state.user.first_name || ''} ${state.user.last_name || ''}`;
4040
},
4141
course: (state) => state.course
4242
};

src/store/modules/users.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,12 @@ export default {
189189
state. merged_users.push(_merged_user);
190190
},
191191
UPDATE_MERGED_USER(state: UserState, _merged_user: MergedUser): void {
192-
const index = state. merged_users.findIndex((u) => u.course_user_id ===_merged_user.course_user_id);
192+
const index = state. merged_users.findIndex((u) => u.course_user_id === _merged_user.course_user_id);
193193
// splice is used so vue3 reacts to changes.
194194
state. merged_users.splice(index, 1, _merged_user);
195195
},
196196
DELETE_COURSE_USER(state: UserState, _course_user: CourseUser): void {
197-
remove(state.course_users, (u) => u.course_user_id ===_course_user.course_user_id);
197+
remove(state.course_users, (u) => u.course_user_id === _course_user.course_user_id);
198198
},
199199
DELETE_MERGED_USER(state: UserState, _merged_user: MergedUser): void {
200200
remove(state. merged_users, (u) => u.course_user_id === _merged_user.course_user_id);

0 commit comments

Comments
 (0)