Fix FSC holdout test cases

Author: esrakartalOpt

optimizely/decision_service.py

@@ -824,9 +824,9 @@ def get_variation_for_holdout(
             self.logger.info(message)
             decide_reasons.append(message)
 
-            # Create Decision for holdout - experiment is None, source is HOLDOUT
+            # Create Decision for holdout - pass holdout dict as experiment so rule_key can be extracted
             holdout_decision: Decision = Decision(
-                experiment=None,
+                experiment=holdout,  # type: ignore[arg-type]
                 variation=variation,
                 source=enums.DecisionSources.HOLDOUT,
                 cmab_uuid=None

optimizely/event/user_event_factory.py

@@ -67,7 +67,9 @@ def create_impression_event(
         variation: Optional[Variation] = None
         experiment_id = None
         if activated_experiment:
-            experiment_id = activated_experiment.id
+            # For holdouts, activated_experiment is a dict; for experiments, it's an Experiment entity
+            experiment_id = (activated_experiment['id'] if isinstance(activated_experiment, dict)
+                             else activated_experiment.id)
 
         if variation_id and flag_key:
             # need this condition when we send events involving forced decisions

optimizely/optimizely.py

@@ -1252,7 +1252,12 @@ def _create_optimizely_decision(
 
         # Create Optimizely Decision Result.
         attributes = user_context.get_user_attributes()
-        rule_key = flag_decision.experiment.key if flag_decision.experiment else None
+        # For holdouts, experiment is a dict; for experiments, it's an Experiment entity
+        if flag_decision.experiment:
+            rule_key = (flag_decision.experiment['key'] if isinstance(flag_decision.experiment, dict)
+                        else flag_decision.experiment.key)
+        else:
+            rule_key = None
         all_variables = {}
         decision_source = flag_decision.source
         decision_event_dispatched = False
@@ -1303,9 +1308,11 @@ def _create_optimizely_decision(
 
         try:
             if flag_decision.experiment is not None:
-                experiment_id = flag_decision.experiment.id
-        except AttributeError:
-            self.logger.warning("flag_decision.experiment has no attribute 'id'")
+                # For holdouts, experiment is a dict; for experiments, it's an Experiment entity
+                experiment_id = (flag_decision.experiment['id'] if isinstance(flag_decision.experiment, dict)
+                                 else flag_decision.experiment.id)
+        except (AttributeError, KeyError, TypeError):
+            self.logger.warning("Unable to extract experiment_id from flag_decision.experiment")
 
         try:
             if flag_decision.variation is not None: