return in finally can swallow exception

[iritkatriel]

In

python-sdk/optimizely/config_manager.py

Line 153 in 40880ff

return

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.