perf(payload): move fields instead of cloning in PayloadBuilderStack::try_build (#19998)

Author: figtracer

crates/payload/basic/src/stack.rs

@@ -194,43 +194,38 @@ where
         &self,
         args: BuildArguments<Self::Attributes, Self::BuiltPayload>,
     ) -> Result<BuildOutcome<Self::BuiltPayload>, PayloadBuilderError> {
-        match args.config.attributes {
-            Either::Left(ref left_attr) => {
+        let BuildArguments { cached_reads, config, cancel, best_payload } = args;
+        let PayloadConfig { parent_header, attributes } = config;
+
+        match attributes {
+            Either::Left(left_attr) => {
                 let left_args: BuildArguments<L::Attributes, L::BuiltPayload> = BuildArguments {
-                    cached_reads: args.cached_reads.clone(),
-                    config: PayloadConfig {
-                        parent_header: args.config.parent_header.clone(),
-                        attributes: left_attr.clone(),
-                    },
-                    cancel: args.cancel.clone(),
-                    best_payload: args.best_payload.clone().and_then(|payload| {
+                    cached_reads,
+                    config: PayloadConfig { parent_header, attributes: left_attr },
+                    cancel,
+                    best_payload: best_payload.and_then(|payload| {
                         if let Either::Left(p) = payload {
                             Some(p)
                         } else {
                             None
                         }
                     }),
                 };
-
                 self.left.try_build(left_args).map(|out| out.map_payload(Either::Left))
             }
-            Either::Right(ref right_attr) => {
+            Either::Right(right_attr) => {
                 let right_args = BuildArguments {
-                    cached_reads: args.cached_reads.clone(),
-                    config: PayloadConfig {
-                        parent_header: args.config.parent_header.clone(),
-                        attributes: right_attr.clone(),
-                    },
-                    cancel: args.cancel.clone(),
-                    best_payload: args.best_payload.clone().and_then(|payload| {
+                    cached_reads,
+                    config: PayloadConfig { parent_header, attributes: right_attr },
+                    cancel,
+                    best_payload: best_payload.and_then(|payload| {
                         if let Either::Right(p) = payload {
                             Some(p)
                         } else {
                             None
                         }
                     }),
                 };
-
                 self.right.try_build(right_args).map(|out| out.map_payload(Either::Right))
             }
         }