Check dirtyState and correct bsonUnserialize dirtystate

Author: tacxou

src/Mvc/Collection.php

@@ -945,6 +945,8 @@ public function bsonUnserialize(array $data): void
 
         $this->collectionsManager = $collectionsManager;
 
+        $this->dirtyState = self::DIRTY_STATE_PERSISTENT;
+
         foreach ($data as $key => $value) {
             $this->writeAttribute($key, $value);
         }
@@ -1406,10 +1408,6 @@ protected static function getResultset(
                 return null;
             }
 
-            if (method_exists($base, 'afterFetch')) {
-                $base->afterFetch();
-            }
-
             return $document;
         }
 
@@ -1418,10 +1416,6 @@ protected static function getResultset(
          */
         $documentsCursor = $mongoCollection->find($conditions, $parameters);
 
-        if (method_exists($base, 'afterFetch')) {
-            $base->afterFetch();
-        }
-
         return $documentsCursor->toArray();
     }
 

tests/integration/Collection/ConstructCest.php

@@ -44,5 +44,6 @@ public function mvcCollectionConstruct(IntegrationTester $I)
 
         $robot = new Robots();
         $I->assertInstanceOf(Robots::class, $robot);
+        $I->assertEquals(Robots::DIRTY_STATE_TRANSIENT, $robot->getDirtyState());
     }
 }

tests/integration/Collection/CreateCest.php

@@ -54,6 +54,7 @@ public function mvcCollectionCreate(IntegrationTester $I)
         $robot = new Robots();
         $robot->first_name = null;
         $I->assertTrue($robot->create());
+        $I->assertEquals(Robots::DIRTY_STATE_PERSISTENT, $robot->getDirtyState());
 
         $search = $this->mongo->selectCollection($this->source)->findOne(['_id' => $robot->getId()]);
         $I->assertNotNull($search);

tests/integration/Collection/FindFirstCest.php

@@ -67,6 +67,7 @@ public function mvcCollectionFindFirst(IntegrationTester $I)
 
         /** @var Robots|bool $firstRobot */
         $firstRobot = Robots::findFirst();
+        $I->assertEquals(Robots::DIRTY_STATE_PERSISTENT, $firstRobot->getDirtyState());
 
         /** @var Robots|bool $robot */
         $robot = Robots::findFirst([['last_name' => 'Nobody']]);

tests/integration/Collection/UpdateCest.php

@@ -65,6 +65,7 @@ public function mvcCollectionUpdate(IntegrationTester $I)
 
         $robot->last_name = 'X';
         $I->assertTrue($robot->update());
+        $I->assertEquals(Robots::DIRTY_STATE_PERSISTENT, $robot->getDirtyState());
 
         $updated = $this->mongo->selectCollection($this->source)->findOne(['_id' => $robot->getId()]);
         $I->assertEquals($updated['last_name'], 'X');