Commit 9567374
Add "dont use this.send in componentWillUnmount" section to README (#15)
Just wanted to clarify a confusing moment: "shall I always call side-effects through sending an action?"
React [docs](https://reactjs.org/docs/react-component.html#componentwillunmount) say that you should never call `setState` in `componentWillUnmount` and `this.send` eventually calls `setState`, so I believe we should make it clear that we shouldn't call `this.send` in `componentWillUnmount` either.
What do you think?1 parent dcba695 commit 9567374
1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
102 | 106 | | |
103 | 107 | | |
104 | 108 | | |
| |||
0 commit comments