-
Notifications
You must be signed in to change notification settings - Fork 166
feat(wifi): add search functionality for filtering WiFi networks #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@jacobgkau Please have a look! |
|
Since this isn't in our Figma design specs, it needs design approval by @maria-komarova first. |
Not sure about the frequency, but the reason they jump around is because they're currently sorted by signal strength, and signal strength of wireless networks often changes slightly (based on the environment) between different scans. Maybe quantizing the signal strength (e.g. chunking in groups of "5-bar, 4-bar," etc.) and then sorting alphabetically within those groups, or a similar solution, could prevent it from happening quite as much? (There would still be some networks going between the different bar groups, but it would prevent e.g. a 3.05-bar and 3.06-bar from swapping in the list constantly.) |
I like this idea, sounds like it would be an improvement. |
- Move search input from top-level to inside "Visible Networks" section - Only show search when 30+ visible networks exist (per designer spec) - Known Networks section now always unfiltered (search only applies to visible) - "No networks found" message only shown in visible section when search active - Addresses designer feedback from PR pop-os#1592
- Clear search_query in on_leave() to prevent stale filter on return - Apply cargo fmt formatting fixes
Updated implementation based on @maria-komarova's feedbackI've updated the implementation to match the design requirements: Changes made:
Screenshots:With fewer than 30 networks (search hidden): With search bar (I have reduced the threshold to 2 instead of 30 for testing): Note on testing:The 30+ threshold means the search bar won't appear in most home/small office environments. For testing, reviewers can temporarily change line 1007 in |
|
Hi @jacobgkau |



Description
This PR adds search/filter functionality to the WiFi settings page, allowing users to easily find WiFi networks when there are many available networks (50+). The search includes both currently visible networks and known/saved networks, even if they're not currently visible.
Fixes #1589
Problem
When there are many WiFi networks available, it becomes difficult to manually search through the list to find a specific SSID. Additionally, the interface reloads every 2-3 seconds, causing the network order to change, making it even harder to locate networks.
Screenshots
Related Issues
Closes #1589