Need Filter for comment replies only

[ronalfy]

I'm not sure where to look in the codebase for this, but I can't seem to find a filter that allows a third-party plugin to override the options for replies only.

@cyberhobo would you be able to take a look at this?

[cyberhobo]

Commentium adds that option for users using our delivery service. It doesn't have a filter.

@Vernal have you verified that you get the behavior you want when the enable replies only setting is on?

[ronalfy]

@cyberhobo would it be possible to add a filter in commentium?

[cyberhobo]

I think a better approach would be to follow the pattern commentium uses to provide your own flood controller implementation. There you could implement exactly the behavior you need, and have less risk of breaking existing features.

[Vernal]

Hey @cyberhobo yes I can confirm the plugin works as it should when in replies-only mode. It works great!

Dylan, what do we need to do to move forward with this. I apologize if you've already said so above (just say it again) but in jason-simpleton thought the question is: how can we make replies-only mode apply to only comments of a certain comment_type?

Or.... what could you say to give @ronalfy the best way forward?

[cyberhobo]

I may honestly be a bit too far gone from this code to make a good recommendation. In my last comment I was thinking that it would probably be safer to build the feature from scratch rather than trying to piggyback on the existing replies only feature, but I'm not even sure that's true. It might be worth experimenting on a branch to see whether adding an 'OR comment type is X' condition to checks for the enable_replies_only setting behaves the way you want. Just keep in mind that you probably don't want to change behavior for users who are not using replies only for regular comments.

[Vernal]

Thanks, Dylan. We’ll poke away more at adding a filter. Best, Jason

…

-- Jason G. Lemieux | Creative Director Vernal Creative and Strategy http://www.vernalcreative.com |  802.821.4059

On Aug 3, 2019, 6:23 PM -0400, Dylan Kuhn ***@***.***>, wrote: I may honestly be a bit too far gone from this code to make a good recommendation. In my last comment I was thinking that it would probably be safer to build the feature from scratch rather than trying to piggyback on the existing replies only feature, but I'm not even sure that's true. It might be worth experimenting on a branch to see whether adding an 'OR comment type is X' condition to checks for the enable_replies_only setting behaves the way you want. Just keep in mind that you probably don't want to change behavior for users who are not using replies only for regular comments. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.