Skip to content

Commit 1d65d22

Browse files
committed
Windows GitHub workers are way too flaky due to lag
1 parent d2fab34 commit 1d65d22

File tree

8 files changed

+3
-19
lines changed

8 files changed

+3
-19
lines changed

.github/workflows/check.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ jobs:
1515
uses: ./.github/workflows/.hatch-run.yml
1616
with:
1717
job-name: "python-{0}"
18-
run-cmd: "hatch test --parallel --cover"
18+
# Retries needed because GitHub workers sometimes lag enough to crash parallel workers
19+
run-cmd: "hatch test --parallel --cover --retries 10"
1920
lint-python:
2021
uses: ./.github/workflows/.hatch-run.yml
2122
with:
@@ -25,7 +26,7 @@ jobs:
2526
uses: ./.github/workflows/.hatch-run.yml
2627
with:
2728
job-name: "python-{0} {1}"
28-
run-cmd: "hatch test --parallel"
29+
run-cmd: "hatch test --parallel --retries 10"
2930
runs-on: '["ubuntu-latest", "macos-latest", "windows-latest"]'
3031
python-version: '["3.11", "3.12", "3.13", "3.14"]'
3132
test-documentation:

tests/__init__.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +0,0 @@
1-
import pytest
2-
3-
from reactpy.testing import GITHUB_ACTIONS
4-
5-
pytestmark = [pytest.mark.flaky(reruns=10 if GITHUB_ACTIONS else 1)]

tests/conftest.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
)
1616
from reactpy.testing.display import _playwright_visible
1717

18-
from . import pytestmark # noqa: F401
19-
2018
REACTPY_ASYNC_RENDERING.set_current(True)
2119
REACTPY_DEBUG.set_current(True)
2220

tests/test_client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
from tests.tooling.common import DEFAULT_TYPE_DELAY
77
from tests.tooling.hooks import use_counter
88

9-
from . import pytestmark # noqa: F401
10-
119
JS_DIR = Path(__file__).parent / "js"
1210

1311

tests/test_html.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
from tests.tooling.common import DEFAULT_TYPE_DELAY
88
from tests.tooling.hooks import use_counter
99

10-
from . import pytestmark # noqa: F401
11-
1210

1311
async def test_script_re_run_on_content_change(display: DisplayFixture):
1412
@component

tests/test_sample.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
from reactpy.testing import DisplayFixture
22
from tests.sample import SampleApp
33

4-
from . import pytestmark # noqa: F401
5-
64

75
async def test_sample_app(display: DisplayFixture):
86
await display.show(SampleApp)

tests/test_testing.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
from reactpy.testing.display import DisplayFixture
1111
from tests.sample import SampleApp
1212

13-
from . import pytestmark # noqa: F401
14-
1513

1614
def test_assert_reactpy_logged_does_not_suppress_errors():
1715
with pytest.raises(RuntimeError, match=r"expected error"):

tests/test_widgets.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
from reactpy.testing import DisplayFixture, poll
66
from tests.tooling.common import DEFAULT_TYPE_DELAY
77

8-
from . import pytestmark # noqa: F401
9-
108
HERE = Path(__file__).parent
119

1210

0 commit comments

Comments
 (0)