lints

Signed-off-by: Andrea Reale <[email protected]>

Author: andrea-reale

docs/snippets/compare_snippet_output.py

@@ -214,7 +214,7 @@ def main() -> None:
             # They should be the same!
             try:
                 if backwards_path.exists():
-                    run_comparison(backwards_path, baseline_path, args.full_dump)
+                    run_comparison(str(backwards_path), baseline_path, args.full_dump)
                 elif args.write_missing_backward_assets:
                     print(f"Writing new backwards-compatibility file to {backwards_path}…")
                     backwards_path.parent.mkdir(parents=True, exist_ok=True)

rerun_py/.non_sdk_mypy.ini

@@ -4,6 +4,8 @@ files = examples/python, docs/snippets, scripts
 exclude = (?x)(
     ^examples/python/objectron/.*
     | ^examples/python/ros_node/.*
+    | examples/python/rrt_star/rrt_star.py
+    | docs/snippets/all/archetypes/arrows3d_simple.py
     | docs/snippets/all/concepts/how_helix_was_logged.py
     | docs/snippets/all/concepts/static/log_static.py
     | docs/snippets/all/concepts/static/log_static_10x.py

rerun_py/pyproject.toml

@@ -35,7 +35,15 @@ name = "Rerun.io"
 text = "MIT OR Apache-2.0"
 
 [project.optional-dependencies]
-tests = ["pytest==8.4.2", "syrupy==5.0.0", "boto3==1.42.5", "pytest_benchmark==5.2.3", "opentelemetry-api==1.39.0", "opentelemetry-sdk==1.39.0", "opentelemetry-exporter-otlp-proto-grpc==1.39.0"]
+tests = [
+  "pytest==8.4.2",
+  "syrupy==5.0.0",
+  "boto3==1.42.5",
+  "pytest_benchmark==5.2.3",
+  "opentelemetry-api==1.39.0",
+  "opentelemetry-sdk==1.39.0",
+  "opentelemetry-exporter-otlp-proto-grpc==1.39.0",
+]
 notebook = ["rerun-notebook==0.28.0-alpha.1+dev"]
 datafusion = ["datafusion==50.1.0"]
 all = ["rerun-sdk[notebook]", "rerun-sdk[datafusion]"]
@@ -303,6 +311,8 @@ module = [
   "torchaudio.*",
   "cv2.*",
   "rerun.*",
+  "opentelemetr.*",
+  "pytest_benchmark.*",
 ]
 ignore_missing_imports = true
 

rerun_py/tests/e2e_redap_tests/conftest.py

@@ -11,7 +11,7 @@
 import pathlib
 import platform
 import re
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
 import pyarrow as pa
 import pytest
@@ -24,6 +24,7 @@
 if TYPE_CHECKING:
     from collections.abc import Generator, Iterator
 
+    from pytest_benchmark.fixture import BenchmarkFixture
     from rerun.catalog import DatasetEntry, TableEntry
     from syrupy import SnapshotAssertion
 
@@ -127,9 +128,10 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
 
 
 @pytest.fixture(scope="session")
-def region(request: pytest.FixtureRequest) -> str:
+def region(request: pytest.FixtureRequest) -> str | None:
     """Get the region for region-specific resources."""
-    return request.config.getoption("--region")
+    region: str | None = request.config.getoption("--region")
+    return region
 
 
 @pytest.fixture(scope="session")
@@ -180,7 +182,8 @@ def readonly_table_uri(resource_prefix: str) -> str:
 @pytest.fixture(scope="session")
 def redap_url(request: pytest.FixtureRequest) -> str | None:
     """Get the redap server URL from command-line options."""
-    return request.config.getoption("--redap-url")
+    url: str | None = request.config.getoption("--redap-url")
+    return url
 
 
 @pytest.fixture(scope="session")
@@ -404,7 +407,11 @@ def telemetry() -> Iterator[Telemetry]:
 
 
 @pytest.hookimpl(trylast=True)
-def pytest_benchmark_update_json(config, benchmarks, output_json) -> None:  # noqa: ARG001
+def pytest_benchmark_update_json(
+    config: pytest.Config,  # noqa: ARG001
+    benchmarks: list[BenchmarkFixture],
+    output_json: dict[str, Any],  # noqa: ARG001
+) -> None:
     """Hook to flush telemetry data at the end of the benchmark session."""
 
     telemetry = Telemetry()

rerun_py/tests/e2e_redap_tests/droid/conftest.py

@@ -19,12 +19,14 @@
 @pytest.fixture(scope="package")
 def droid_dataset_name(request: pytest.FixtureRequest) -> str:
     """Fixture to provide access to the droid dataset."""
-    return request.config.getoption("--droid-dataset")
+    name: str = request.config.getoption("--droid-dataset")
+    return name
 
 
 @pytest.fixture(scope="package")
 def droid_preregister_dataset(request: pytest.FixtureRequest) -> bool:
-    return request.config.getoption("--droid-preregister-dataset")
+    should_register: bool = request.config.getoption("--droid-preregister-dataset")
+    return should_register
 
 
 @pytest.fixture(scope="package")
@@ -56,7 +58,8 @@ def aws_dataset_manifest(aws_regional_dataset_manifest_path: str) -> dict[str, A
     s3 = boto3.client("s3")
 
     response = s3.get_object(Bucket=bucket, Key=key)
-    return json.loads(response["Body"].read().decode("utf-8"))
+    manifest: dict[str, Any] = json.loads(response["Body"].read().decode("utf-8"))
+    return manifest
 
 
 @pytest.fixture(scope="package")

rerun_py/tests/e2e_redap_tests/droid/test_droid.py

@@ -193,7 +193,7 @@ def lookup_embedding_using_index_values_body(dataset: DatasetEntry) -> None:
 
     # Currently `using_index_values` will actually give us a single result, and so we have the option
     # to use that to improve the performance of this query.
-    # TODO(https://linear.app/rerun/issue/DPF-1818/): Decide if this is actually something we want to depend on
+    # TODO(DPF#1818): Decide if this is actually something we want to depend on
 
     result = (
         dataset.dataframe_query_view(index="real_time", contents="/camera/wrist/embedding")
@@ -228,41 +228,6 @@ def sample_index_values_body(dataset: DatasetEntry) -> None:
     assert len(result) > 0
 
 
-@pytest.mark.benchmark(group="droid")
-def test_sample_index_values_chunk_ids(benchmark: BenchmarkFixture, tracing: trace.Span, dataset: DatasetEntry) -> None:
-    """Find the Chunk IDs needed for `sample_index_values`."""
-    tracing.set_attribute("test_dataset", dataset.name)
-    benchmark.pedantic(
-        sample_index_values_chunk_ids_body,
-        args=(dataset,),
-        rounds=1,
-    )
-
-
-def sample_index_values_chunk_ids_body(dataset: DatasetEntry) -> None:
-    """Find the Chunk IDs needed for `sample_index_values`."""
-    wrist = dataset.dataframe_query_view(
-        index="log_tick",
-        contents="/camera/wrist/embedding /thumbnail/camera/wrist",
-    )
-
-    sampled_times = [0, 100, 200, 500, 1000, 2000]
-    results = (wrist.filter_index_values(sampled_times).fill_latest_at()).get_chunk_ids()
-    for batch in results:
-        assert batch.num_rows > 0
-
-
-@pytest.mark.benchmark(group="droid")
-def test_align_fixed_frequency(benchmark: BenchmarkFixture, tracing: trace.Span, dataset: DatasetEntry) -> None:
-    """Align two columns to a fixed frequency."""
-    tracing.set_attribute("test_dataset", dataset.name)
-    benchmark.pedantic(
-        align_fixed_frequency_body,
-        args=(dataset,),
-        rounds=1,
-    )
-
-
 def align_fixed_frequency_body(dataset: DatasetEntry) -> None:
     """Align two columns to a fixed frequency."""
     # Grab the cheaper column to get range of times until we can pushdown

scripts/ci/compare.py

@@ -120,9 +120,9 @@ def compare(
                 current = current_bytes / div
 
             if previous == current:
-                change_pct = 0  # e.g. both are zero
+                change_pct = 0.0  # e.g. both are zero
             elif previous == 0:
-                change_pct = 100
+                change_pct = 100.0
             else:
                 change_pct = 100 * (current - previous) / previous
 

scripts/fetch_crashes.py

@@ -164,7 +164,7 @@ def count_uniques(backtrace_item: tuple[str, list[Any]]) -> int:
         "\n"
         "Backtrace:\n"
         "```\n"
-        f"   {backtrace.decode('utf-8')}\n"
+        f"   {backtrace}\n"
         "```\n"
         "-------------------------------------------------------------------------------\n",
     )

scripts/lint.py

@@ -1540,7 +1540,7 @@ def main() -> None:
         tracked_files = [item[1].path for item in repo.index.iter_blobs()]
         for filepath in tracked_files:
             # TODO do this with pathlib for general sep types
-            filepath = "./" + filepath
+            filepath = "./" + str(filepath)
             extension = filepath.split(".")[-1]
             if extension in extensions:
                 if filepath.startswith(exclude_paths):