Skip to content

Commit 696d9eb

Browse files
committed
improve comment wording
1 parent 24c76f7 commit 696d9eb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

crates/store/re_data_loader/src/loader_urdf.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,8 @@ fn log_link(
528528
let visual_name = name.clone().unwrap_or_else(|| format!("visual_{i}"));
529529
let visual_entity = link_entity / EntityPathPart::new(visual_name.clone());
530530

531-
// We have to make sure that the frame ID is unique, otherwise we might end up with multiple "visual_0" etc.
532-
// Prefix with the link name.
531+
// Prefix with the link name, otherwise we might end up with multiple coordinate frames named "visual_0" etc.
532+
// Note that this doesn't apply to the entity path part, there it's fine to have e.g. /base/visual_0 and /base/link1/visual_0.
533533
let visual_frame_id = format!("{link_name}_{visual_name}");
534534

535535
// Prefer inline defined material properties if present, otherwise fall back to global material.
@@ -580,8 +580,8 @@ fn log_link(
580580
let collision_name = name.clone().unwrap_or_else(|| format!("collision_{i}"));
581581
let collision_entity = link_entity / EntityPathPart::new(collision_name.clone());
582582

583-
// We have to make sure that the frame ID is unique, otherwise we might end up with multiple "collision_0" etc.
584-
// Prefix with the link name.
583+
// Prefix with the link name, otherwise we might end up with multiple coordinate frames named "collision_0" etc.
584+
// Note that this doesn't apply to the entity path part, there it's fine to have e.g. /base/collision_0 and /base/link1/collision_0.
585585
let collision_frame_id = format!("{link_name}_{collision_name}");
586586

587587
send_transform(

0 commit comments

Comments
 (0)