Skip to content

SimpleMPS algorithm breaks due to integer overflow of cell coordinates #2

@drlight-code

Description

@drlight-code

The current SimpleMPS code creates points that lie out of the expected bounding box, i.e. outside the grid coordinates. Particularly if I check all generated points for x > 0 the assertion fails, but only very randomly. I didn't debug further, but if I switch to the commented code with pool updates as defined here https://github.com/sandialabs/DeterministicMPS/blob/main/source/SimpleMPS.cpp#L124-L143 the problem vanishes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions