Issue #1068: migrate to checkstyle 11.0.0

Author: AmitKumarDeoghoria

.circleci/config.yml

@@ -7,7 +7,7 @@ jobs:
     parameters:
       image-name:
         type: string
-        default: "cimg/openjdk:17.0.7"
+        default: "cimg/openjdk:17.0.8"
         description: "docker image to use"
       command:
         description: "command to run"
@@ -52,7 +52,6 @@ workflows:
       - validate-with-maven-script:
           name: "checkstyle-regression"
           command: "./.ci/validation.sh checkstyle-regression"
-      # until https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/1039
-      # - validate-with-maven-script:
-      #    name: "eclipse-analysis"
-      #    command: "./.ci/validation.sh eclipse-analysis"
+      - validate-with-maven-script:
+          name: "eclipse-analysis"
+          command: "./.ci/validation.sh eclipse-analysis"

eclipse-pom.xml

@@ -27,12 +27,13 @@
 
   <repositories>
     <repository>
-      <id>2020-09</id>
+      <id>eclipse-2020-09</id>
       <layout>p2</layout>
-      <url>https://download.eclipse.org/releases/2020-09</url>
+      <url>https://download.eclipse.org/releases/2020-09/</url>
     </repository>
   </repositories>
 
+
   <build>
     <plugins>
       <plugin>

eclipsecs-sevntu-plugin-feature/pom.xml

@@ -10,7 +10,6 @@
     <version>1.44.1</version>
   </parent>
 
-  <groupId>com.github.sevntu-checkstyle</groupId>
   <artifactId>com.github.sevntu.checkstyle.checks.feature</artifactId>
   <packaging>eclipse-feature</packaging>
   <name>Extension for eclipse-cs Plugin with additional Checks</name>

eclipsecs-sevntu-plugin/pom.xml

@@ -12,7 +12,6 @@
     <version>1.44.1</version>
   </parent>
 
-  <groupId>com.github.sevntu-checkstyle</groupId>
   <artifactId>eclipsecs-sevntu-plugin</artifactId>
   <packaging>eclipse-plugin</packaging>
 
@@ -26,14 +25,13 @@
   </licenses>
 
   <properties>
-    <eclipsecs.version>10.4.0-SNAPSHOT</eclipsecs.version>
+    <eclipsecs.version>11.0.0-SNAPSHOT</eclipsecs.version>
     <!-- verify time version -->
-    <checkstyle.version>10.26.1</checkstyle.version>
+    <checkstyle.version>11.0.0</checkstyle.version>
     <checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle-checks.xml</checkstyle.configLocation>
     <checkstyle.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java.header</checkstyle.header>
     <checkstyle.regexp.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header</checkstyle.regexp.header>
     <antrun.plugin.version>3.1.0</antrun.plugin.version>
-    <checkstyle.java.version>17</checkstyle.java.version>
   </properties>
 
   <dependencies>

sevntu-checks/config/suppressions.xml

@@ -38,5 +38,7 @@
     <!-- until https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/1038 -->
     <suppress checks="JavadocParagraph" message="tag should be preceded with an empty line."/>
     <suppress checks="JavadocParagraph" message="Redundant .* tag."/>
+    <!--one down the checking for eclipse pref file  -->
+    <suppress files="org\.eclipse\.jdt\.core\.prefs-e" checks="LineLength"/>
 
 </suppressions>

sevntu-checks/org.eclipse.jdt.core.prefs-e

@@ -0,0 +1,144 @@
+# The list of options supported by Eclipse compiler
+# https://github.com/eclipse/eclipse.jdt.core/blame/master/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java
+
+org.eclipse.jdt.core.compiler.problem.APILeak=error
+org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=error
+org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=error
+org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.comparingIdentical=error
+org.eclipse.jdt.core.compiler.problem.deadCode=error
+org.eclipse.jdt.core.compiler.problem.deadCodeInTrivialIfStatement=error
+org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=enabled
+org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=enabled
+org.eclipse.jdt.core.compiler.problem.discouragedReference=error
+org.eclipse.jdt.core.compiler.problem.emptyStatement=error
+org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+# The severity is set to 'warning', since we need to suppress it in some cases.
+org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=warning
+org.eclipse.jdt.core.compiler.problem.fallthroughCase=error
+org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
+org.eclipse.jdt.core.compiler.problem.fieldHiding=error
+org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=error
+org.eclipse.jdt.core.compiler.problem.finalParameterBound=error
+org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
+org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=error
+org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=enabled
+org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=error
+org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=error
+org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=error
+org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=error
+org.eclipse.jdt.core.compiler.problem.localVariableHiding=error
+org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=error
+org.eclipse.jdt.core.compiler.problem.missingDefaultCase=error
+org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=error
+org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=enabled
+org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=error
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=protected
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagDescription=all_standard_tags
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=enabled
+org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=protected
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
+org.eclipse.jdt.core.compiler.problem.missingSerialVersion=error
+org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=error
+org.eclipse.jdt.core.compiler.problem.noEffectAssignment=error
+org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=error
+org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=error
+org.eclipse.jdt.core.compiler.problem.nonnullTypeVariableFromLegacyInvocation=error
+org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
+org.eclipse.jdt.core.compiler.problem.nullReference=error
+org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
+org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=error
+org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=error
+org.eclipse.jdt.core.compiler.problem.parameterAssignment=error
+org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=error
+org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=error
+# The option rawTypeReference is set to warning to allow us suppress it in code for old code
+org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
+org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=error
+org.eclipse.jdt.core.compiler.problem.redundantNullCheck=error
+org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=error
+org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=error
+org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=error
+org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=error
+org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=error
+org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error
+org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=enabled
+org.eclipse.jdt.core.compiler.problem.tasks=enabled
+org.eclipse.jdt.core.compiler.problem.terminalDeprecation=error
+org.eclipse.jdt.core.compiler.problem.typeParameterHiding=error
+org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
+# The option uncheckedTypeOperation is set to warning to allow us suppress it in code for old code
+org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
+org.eclipse.jdt.core.compiler.problem.unclosedCloseable=error
+org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=error
+org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=error
+org.eclipse.jdt.core.compiler.problem.uninternedIdentityComparison=enabled
+org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentType=error
+org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentTypeStrict=enabled
+org.eclipse.jdt.core.compiler.problem.unlikelyEqualsArgumentType=error
+org.eclipse.jdt.core.compiler.problem.unnecessaryElse=error
+org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=error
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled
+org.eclipse.jdt.core.compiler.problem.unusedImport=error
+org.eclipse.jdt.core.compiler.problem.unusedLabel=error
+org.eclipse.jdt.core.compiler.problem.unusedLocal=error
+org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=error
+org.eclipse.jdt.core.compiler.problem.unusedParameter=error
+org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
+org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=error
+org.eclipse.jdt.core.compiler.problem.unusedTypeArgumentsForMethodInvocation=error
+org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
+org.eclipse.jdt.core.compiler.problem.unusedWarningToken=error
+org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=error
+
+# Ignore section
+
+# Requires us to box and unbox all conversions manually which seems unnecessary.
+org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
+# We can not enforce this rule as we are library and we keep deprecated stuff for some time
+org.eclipse.jdt.core.compiler.problem.deprecation=ignore
+# Preview features can be enabled be enabled only at source level 14, we are using 8
+org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
+# We don't document the tests. As we cannot exclude them, this check is muted.
+org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
+# We don't document the tests. As we cannot exclude them, this check is muted.
+org.eclipse.jdt.core.compiler.problem.missingJavadocTags=ignore
+# We will not put all String values to resources, it does not make sense in our project
+org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
+# Incompatible with visitToken and similar API.
+org.eclipse.jdt.core.compiler.problem.overridingMethodWithoutSuperInvocation=ignore
+# Too much complaining about potential null code but tests and pitests don't show anything.
+org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
+# Complains about any resource that leaves a method that isn't closed first.
+org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
+# Too many false positives for methods that should be static but would cause issues.
+org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
+# We should print all errors
+org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
+org.eclipse.jdt.core.compiler.problem.suppressWarnings=disabled
+org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=disabled
+# Checkstyle doesn't mind synthetic methods.
+org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
+# IntelliJ requires the type casts while this wants it removed.
+org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
+# We have another check that ensures fields have this when necessary.
+# This asks for this on all fields.
+org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
+# We should print errors on all throwables
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=disabled
+# We shouldn't print errors on overriding methods that don't make use of exceptions
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
+# We use checkstyle rule, special cases could be suppressed by configs out of code
+org.eclipse.jdt.core.compiler.problem.unusedExceptionParameter=ignore
+# For an event handler it is not possible to remove unneeded parameter nor use it.
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
+# For an event handler it is not possible to remove unneeded parameter nor use it.
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled