fix: is.class for minified class expression #217
Merged
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a situation recently where code was working in development, but then exhibited different behavior after the code was run through a minifier. Narrowed it down to the
is.classcheck, which incorrectly assumes there is always trailing whitespace after theclasskeyword. In a class expression with an anonymous class,class{...is valid syntax.I initially tried adding the failing test case totest/test.tsbut it seems thetsimpis somehow modifying the source and that the whitespace is re-added after theclasskeyword. I didn't dig into it, and instead added atest/test-node.jswith a note about why it was needed.Edit: Thought of another way to keep the whitespace from being mangled in transpilation, returning the class from a Function constructor. This way there's no
.js/ separate files for the tests.