Skip to content

Commit 3b3ec11

Browse files
jhrozekjhrozek
authored
Use mcp.LATEST_PROTOCOL_VERSION in E2E tests (#2793)
Replace hardcoded MCP protocol version ("2024-11-05") with mcp.LATEST_PROTOCOL_VERSION from the mcp-go SDK across all VirtualMCP E2E tests.
1 parent ded581d commit 3b3ec11

File tree

7 files changed

+11
-13
lines changed

7 files changed

+11
-13
lines changed

‎test/e2e/thv-operator/virtualmcp/suite_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ import (
2828
const (
2929
// fetchToolName is the name of the fetch tool used in tests
3030
fetchToolName = "fetch"
31-
// mcpProtocolVersion is the MCP protocol version used in tests
32-
mcpProtocolVersion = "2024-11-05"
3331
)
3432

3533
var (

‎test/e2e/thv-operator/virtualmcp/virtualmcp_aggregation_filtering_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ var _ = Describe("VirtualMCPServer Aggregation Filtering", Ordered, func() {
223223
Expect(err).ToNot(HaveOccurred())
224224

225225
initRequest := mcp.InitializeRequest{}
226-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
226+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
227227
initRequest.Params.ClientInfo = mcp.Implementation{
228228
Name: "toolhive-filtering-test",
229229
Version: "1.0.0",
@@ -283,7 +283,7 @@ var _ = Describe("VirtualMCPServer Aggregation Filtering", Ordered, func() {
283283
Expect(err).ToNot(HaveOccurred())
284284

285285
initRequest := mcp.InitializeRequest{}
286-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
286+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
287287
initRequest.Params.ClientInfo = mcp.Implementation{
288288
Name: "toolhive-filtering-test",
289289
Version: "1.0.0",

‎test/e2e/thv-operator/virtualmcp/virtualmcp_auth_discovery_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ var _ = Describe("VirtualMCPServer Auth Discovery", Ordered, func() {
520520
Expect(err).ToNot(HaveOccurred())
521521

522522
initRequest := mcp.InitializeRequest{}
523-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
523+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
524524
initRequest.Params.ClientInfo = mcp.Implementation{
525525
Name: "toolhive-auth-discovery-test",
526526
Version: "1.0.0",
@@ -560,7 +560,7 @@ var _ = Describe("VirtualMCPServer Auth Discovery", Ordered, func() {
560560
Expect(err).ToNot(HaveOccurred())
561561

562562
initRequest := mcp.InitializeRequest{}
563-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
563+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
564564
initRequest.Params.ClientInfo = mcp.Implementation{
565565
Name: "toolhive-auth-discovery-test",
566566
Version: "1.0.0",

‎test/e2e/thv-operator/virtualmcp/virtualmcp_discovered_mode_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ var _ = Describe("VirtualMCPServer Discovered Mode", Ordered, func() {
258258
Expect(err).ToNot(HaveOccurred())
259259

260260
initRequest := mcp.InitializeRequest{}
261-
initRequest.Params.ProtocolVersion = "2024-11-05"
261+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
262262
initRequest.Params.ClientInfo = mcp.Implementation{
263263
Name: "toolhive-e2e-test",
264264
Version: "1.0.0",
@@ -307,7 +307,7 @@ var _ = Describe("VirtualMCPServer Discovered Mode", Ordered, func() {
307307
Expect(err).ToNot(HaveOccurred())
308308

309309
initRequest := mcp.InitializeRequest{}
310-
initRequest.Params.ProtocolVersion = "2024-11-05"
310+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
311311
initRequest.Params.ClientInfo = mcp.Implementation{
312312
Name: "toolhive-e2e-test",
313313
Version: "1.0.0",

‎test/e2e/thv-operator/virtualmcp/virtualmcp_inline_auth_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ var _ = Describe("VirtualMCPServer Inline Auth with Anonymous Incoming", Ordered
173173
Expect(err).ToNot(HaveOccurred())
174174

175175
initRequest := mcp.InitializeRequest{}
176-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
176+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
177177
initRequest.Params.ClientInfo = mcp.Implementation{
178178
Name: "toolhive-e2e-test",
179179
Version: "1.0.0",
@@ -430,7 +430,7 @@ var _ = Describe("VirtualMCPServer Inline Auth with OIDC Incoming", Ordered, fun
430430
err = mcpClient.Start(ctx)
431431
if err == nil {
432432
initRequest := mcp.InitializeRequest{}
433-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
433+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
434434
initRequest.Params.ClientInfo = mcp.Implementation{
435435
Name: "toolhive-e2e-test",
436436
Version: "1.0.0",

‎test/e2e/thv-operator/virtualmcp/virtualmcp_tokenexchange_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ var _ = Describe("VirtualMCPServer Token Exchange Auth", Ordered, func() {
287287
Expect(err).ToNot(HaveOccurred())
288288

289289
initRequest := mcp.InitializeRequest{}
290-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
290+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
291291
initRequest.Params.ClientInfo = mcp.Implementation{
292292
Name: "toolhive-e2e-test",
293293
Version: "1.0.0",

‎test/e2e/thv-operator/virtualmcp/virtualmcp_yardstick_base_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ var _ = Describe("VirtualMCPServer Yardstick Base", Ordered, func() {
231231
Expect(err).ToNot(HaveOccurred())
232232

233233
initRequest := mcp.InitializeRequest{}
234-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
234+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
235235
initRequest.Params.ClientInfo = mcp.Implementation{
236236
Name: "toolhive-yardstick-test",
237237
Version: "1.0.0",
@@ -293,7 +293,7 @@ var _ = Describe("VirtualMCPServer Yardstick Base", Ordered, func() {
293293
Expect(err).ToNot(HaveOccurred())
294294

295295
initRequest := mcp.InitializeRequest{}
296-
initRequest.Params.ProtocolVersion = mcpProtocolVersion
296+
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
297297
initRequest.Params.ClientInfo = mcp.Implementation{
298298
Name: "toolhive-yardstick-test",
299299
Version: "1.0.0",

0 commit comments

Comments
 (0)