fix: reconnect deriveds inside branch effects

hmnd · hmnd · commit 9522cb2574dc · 2025-12-14T23:06:02.000-08:00
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -28,7 +28,6 @@ import { old_values } from './reactivity/sources.js';
 import {
 	destroy_derived_effects,
 	execute_derived,
-	current_async_effect,
 	recent_async_deriveds,
 	update_derived
 } from './reactivity/deriveds.js';
@@ -629,7 +628,11 @@ export function get(signal) {
 			update_derived(derived);
 		}
 
-		if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {
+		if (
+			is_updating_effect &&
+			(derived.f & CONNECTED) === 0 &&
+			(effect_tracking() || (active_effect !== null && (active_effect.f & BRANCH_EFFECT) !== 0))
+		) {
 			reconnect(derived);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ import { old_values } from './reactivity/sources.js';`
`28`	`28`	`import {`
`29`	`29`	`destroy_derived_effects,`
`30`	`30`	`execute_derived,`
`31`		`- current_async_effect,`
`32`	`31`	`recent_async_deriveds,`
`33`	`32`	`update_derived`
`34`	`33`	`} from './reactivity/deriveds.js';`
`@@ -629,7 +628,11 @@ export function get(signal) {`
`629`	`628`	`update_derived(derived);`
`630`	`629`	`}`
`631`	`630`
`632`		`- if (is_updating_effect && effect_tracking() && (derived.f & CONNECTED) === 0) {`
	`631`	`+ if (`
	`632`	`+ is_updating_effect &&`
	`633`	`+ (derived.f & CONNECTED) === 0 &&`
	`634`	`+ (effect_tracking() \|\| (active_effect !== null && (active_effect.f & BRANCH_EFFECT) !== 0))`
	`635`	`+ ) {`
`633`	`636`	`reconnect(derived);`
`634`	`637`	`}`
`635`	`638`	`}`