Skip to content

Commit 7a3ab23

Browse files
authored
__CFBinaryPlistGetOffsetForValueFromDictionary3 returns null instead of false (#5307)
I guess this has worked when compiled, but this is semantically wrong.
1 parent d76486d commit 7a3ab23

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Sources/CoreFoundation/CFBinaryPList.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,7 @@ bool __CFBinaryPlistGetOffsetForValueFromDictionary3(const uint8_t *databytes, u
10551055
const uint8_t *ptr = NULL;
10561056
uint8_t marker = 0;
10571057
const uint8_t *extent = NULL;
1058-
if (!__CFBinaryPList_beginDictionaryParse(databytes, datalen, startOffset, trailer, &cnt, &ptr, &marker, &extent)) FAIL_NULL;
1058+
if (!__CFBinaryPList_beginDictionaryParse(databytes, datalen, startOffset, trailer, &cnt, &ptr, &marker, &extent)) FAIL_FALSE;
10591059

10601060
// For short keys (15 bytes or less) in ASCII form, we can do a quick comparison check
10611061
// We get the pointer or copy the buffer here, outside of the loop

0 commit comments

Comments
 (0)