Skip to content

Commit 3a90ba9

Browse files
[Devansh/Saranya] Update version to v1.1.0; Update Readme
1 parent 4422810 commit 3a90ba9

File tree

2 files changed

+28
-31
lines changed

2 files changed

+28
-31
lines changed

README.md

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ Paste the URL in the input field on the home page.
113113

114114
That's it!
115115

116-
**Note**: When using the BYOR app on [radar.thoughtworks.com](https://radar.thoughtworks.com), the ring and quadrant names should be among the values mentioned in the [example above](#setting-up-your-data). This holds good for Google Sheet, CSV or JSON inputs.
116+
**_Note:_** When using the BYOR app on [radar.thoughtworks.com](https://radar.thoughtworks.com), the ring and quadrant names should be among the values mentioned in the [example above](#setting-up-your-data). This holds good for Google Sheet, CSV or JSON inputs.
117117
For a self hosted BYOR app, there is no such condition on the names. Instructions to specify custom names are in the [next section](#more-complex-usage).
118118

119119
Check [this page](https://www.thoughtworks.com/radar/byor) for step by step guidance.
@@ -153,8 +153,8 @@ export ADOBE_LAUNCH_SCRIPT_URL=[Adobe Launch URL]
153153
To specify custom ring and/or quadrant names, add the following environment variables with the desired values.
154154

155155
```
156-
export RINGS=['Adopt', 'Trial', 'Assess', 'Hold']
157-
export QUADRANTS=['Techniques', 'Platforms', 'Tools', 'Languages & Frameworks']
156+
export RINGS='["Adopt", "Trial", "Assess", "Hold"]'
157+
export QUADRANTS='["Techniques", "Platforms", "Tools", "Languages & Frameworks"]'
158158
```
159159

160160
## Docker Image
@@ -163,11 +163,14 @@ We have released BYOR as a docker image for our users. The image is available in
163163

164164
```
165165
$ docker pull wwwthoughtworks/build-your-own-radar
166-
$ docker run --rm -p 8080:80 -e CLIENT_ID="[Google Client ID]" wwwthoughtworks/build-your-own-radar
166+
$ docker run --rm -p 8080:80 -e CLIENT_ID="[Google Client ID]" wwwthoughtworks/build-your-own-radar:latest
167167
$ open http://localhost:8080
168168
```
169169

170-
Note: The other environment variables mentioned in the previous section can be used with `docker run` as well.
170+
**_Notes:_**
171+
172+
- The other environment variables mentioned in the previous section can be used with `docker run` as well.
173+
- Docker images for all the [releases](https://github.com/thoughtworks/build-your-own-radar/releases) are available with their respective tags (eg: `wwwthoughtworks/build-your-own-radar:v1.0.0`).
171174

172175
### Advanced option - Docker image with a CSV/JSON file from the host machine
173176

@@ -178,20 +181,20 @@ You can check your setup by clicking on "Build my radar" and by loading the `csv
178181

179182
```
180183
$ docker pull wwwthoughtworks/build-your-own-radar
181-
$ docker run --rm -p 8080:80 -e SERVER_NAMES="localhost 127.0.0.1" -v /mnt/radar/files/:/opt/build-your-own-radar/files wwwthoughtworks/build-your-own-radar
184+
$ docker run --rm -p 8080:80 -e SERVER_NAMES="localhost 127.0.0.1" -v /mnt/radar/files/:/opt/build-your-own-radar/files wwwthoughtworks/build-your-own-radar:latest
182185
$ open http://localhost:8080
183186
```
184187

185188
This will:
186189

187190
- Spawn a server that will listen locally on port 8080.
188191
- Mount the host volume on `/mnt/radar/files/` into the container on `/opt/build-your-own-radar/files/`.
189-
- Open http://localhost:8080 and for the URL enter: http://localhost:8080/files/${NAME_OF_YOUR_FILE}.${EXTENSION_OF_YOUR_FILE[csv/json]}. It needs to be a csv/json file.
192+
- Open http://localhost:8080 and for the URL enter: `http://localhost:8080/files/<NAME_OF_YOUR_FILE>.<EXTENSION_OF_YOUR_FILE[csv/json]>`. It needs to be a csv/json file.
190193

191194
You can now work locally on your machine, updating the csv/json file and render the result back on your browser.
192195
There is a sample csv and json file placed in `spec/end_to_end_tests/resources/localfiles/` for reference.
193196

194-
**_Note:_**
197+
**_Notes:_**
195198

196199
- If API Key is also available, same can be provided to the `docker run` command as `-e API_KEY=[Google API Key]`.
197200
- For setting the `publicPath` in the webpack config while using this image, the path can be passed as an environment variable called `ASSET_PATH`.
@@ -201,38 +204,32 @@ There is a sample csv and json file placed in `spec/end_to_end_tests/resources/l
201204
All tasks are defined in `package.json`.
202205

203206
Pull requests are welcome; please write tests whenever possible.
204-
Make sure you have nodejs installed.
207+
Make sure you have nodejs installed. You can run `nvm use` to use the version used by this repo.
205208

206209
- `git clone [email protected]:thoughtworks/build-your-own-radar.git`
207210
- `npm install`
208-
- `npm run quality` - to run your tests
211+
- `npm run quality` - to run the linter and the unit tests
209212
- `npm run dev` - to run application in localhost:8080. This will watch the .js and .css files and rebuild on file changes
210213

211214
## End to End Tests
212215

213-
To run End to End tests in headless mode
216+
To run End to End tests, start the dev server and follow the required steps below:
214217

215-
- add a new environment variable 'TEST_URL' and set it to 'http://localhost:8080/'
216-
- add a new environment variable 'TEST_ENV' and set it to 'development' or 'production'
217-
- `npm run test:e2e`
218+
- To run in headless mode:
218219

219-
To run End to End tests in debug mode
220+
- add a new environment variable `TEST_URL` and set it to 'http://localhost:8080/'
221+
- `npm run test:e2e-headless`
220222

221-
- add a new environment variable 'TEST_URL' and set it to 'http://localhost:8080/'
222-
- add a new environment variable 'TEST_ENV' and set it to 'development' or 'production'
223-
- `npm run start`
224-
- Click on 'Run all specs' in cypress window
223+
- To run in debug mode:
224+
- add a new environment variable `TEST_URL` and set it to 'http://localhost:8080/'
225+
- `npm run e2e`
226+
- Select 'E2E Testing' and choose the browser
227+
- Click on the spec to run it's tests
225228

226-
**_Note:_** Currently, end to end tests are not working, as the flow requires Google login via prompt, which Cypress does not support. We are working to find some alternative solution for this.
229+
**_Note:_** Currently, end to end tests are not supported for private Google Sheets, as it requires interacting with the Google One Tap popup.
227230

228231
### Don't want to install node? Run with one line docker
229232

230-
$ docker run -p 8080:8080 -v $PWD:/app -w /app -it node:10.15.3 /bin/sh -c 'npm install && npm run dev'
231-
232-
**_Note:_** If you are facing Node-sass compile error while running, please prefix the command `npm rebuild node-sass` before `npm run dev`. like this
233-
234-
```
235-
npm install && npm rebuild node-sass && npm run dev
236-
```
233+
$ docker run -p 8080:8080 -v $PWD:/app -w /app -it node:18 /bin/sh -c 'npm install && npm run dev'
237234

238-
After building it will start on `localhost:8080`
235+
After building it will start on `localhost:8080`.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "build-your-own-radar",
3-
"version": "1.0.0",
3+
"version": "1.1.0",
44
"description": "",
55
"main": "index.js",
66
"scripts": {
@@ -79,8 +79,8 @@
7979
]
8080
},
8181
"engines": {
82-
"node": ">=14",
83-
"npm": "8"
82+
"node": ">=18",
83+
"npm": ">=9"
8484
},
8585
"private": true
8686
}

0 commit comments

Comments
 (0)