exchanges: Add V2 Crypto.com exchange support #1122

samuael · 2023-01-29T19:10:49Z

PR Description

This pull request adds a code implementation for version 2 of the Crypto.com exchange. The implementation supports REST and web-socket functionalities. All the REST, WebSocket endpoints, and wrapper functions are tested. My code adheres to the GCT style standards used by other exchanges.
Fixed some errors with the help of linter(golangci-lint), and unit tests. REST and WebSocket endpoint methods that have no support from the GCT wrapper are also implemented for future use.

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as the item is complete.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also, consider improving test coverage whilst working on a certain feature or package.

go test ./... -race
golangci-lint run
Test X

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally and on Github Actions/AppVeyor with my changes
Any dependent changes have been merged and published in downstream modules

shazbert

Looks good! Just a basic look over. Well done.

exchanges/cryptodotcom/cryptodotcom.go

shazbert · 2023-01-30T02:57:02Z

exchanges/cryptodotcom/cryptodotcom.go

+	publicGetValuations             = "public/get-valuations"               // skipped
+	publicGetExpiredSettlementPrice = "public/get-expired-settlement-price" // skipped
+	publicGetInsurance              = "public/get-insurance"                // skipped


Why skipped?

exchanges/cryptodotcom/cryptodotcom.go

exchanges/cryptodotcom/cryptodotcom_wrapper.go

shazbert · 2023-01-30T04:18:14Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+		return nil, currency.ErrCurrencyPairEmpty
+	}
+	var notional float64
+	switch s.Type {


NOTE: Test for when both s.Amount and notional are sent.

exchanges/cryptodotcom/cryptodotcom_wrapper.go

testdata/configtest.json

shazbert

Thanks for that, just a quick review of last changes. Once completed I will start doing end point tests.

exchanges/cryptodotcom/cryptodotcom.go

exchanges/cryptodotcom/cryptodotcom_test.go

shazbert · 2023-02-06T04:08:24Z

exchanges/cryptodotcom/cryptodotcom_types.go

 	TriggerPrice   float64    `json:"trigger_price"`
 }

+func (arg *CreateOrderParam) getCreateParamMap() (map[string]interface{}, error) {


This needs full test coverage and utilizing if !errors.Is(err, errGlobalError) { }

exchanges/cryptodotcom/cryptodotcom_wrapper.go

codecov · 2023-02-07T21:53:00Z

Codecov Report

Attention: Patch coverage is 33.89021% with 1662 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (609011a) to head (6bc8907).

Files with missing lines	Patch %	Lines
exchanges/cryptodotcom/cryptodotcom_wrapper.go	30.91%	631 Missing and 55 partials ⚠️
exchanges/cryptodotcom/cryptodotcom.go	26.82%	461 Missing and 11 partials ⚠️
exchanges/cryptodotcom/cryptodotcom_websocket.go	47.57%	231 Missing and 39 partials ⚠️
...s/cryptodotcom/cryptodotcom_websocket_endpoints.go	0.00%	210 Missing ⚠️
exchanges/cryptodotcom/cryptodotcom_types.go	82.85%	8 Missing and 4 partials ⚠️
exchanges/cryptodotcom/cryptodotcom_convert.go	57.89%	8 Missing ⚠️
exchanges/order/orders.go	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   36.90%   36.85%   -0.05%     
==========================================
  Files         414      421       +7     
  Lines      180492   183006    +2514     
==========================================
+ Hits        66607    67449     +842     
- Misses     106046   107620    +1574     
- Partials     7839     7937      +98

Files with missing lines	Coverage Δ
engine/helpers.go	`80.15% <100.00%> (+0.05%)`	⬆️
exchanges/asset/asset.go	`93.89% <100.00%> (+0.19%)`	⬆️
exchanges/cryptodotcom/ratelimiter.go	`100.00% <100.00%> (ø)`
exchanges/support.go	`100.00% <ø> (ø)`
exchanges/order/orders.go	`90.67% <50.00%> (-0.33%)`	⬇️
exchanges/cryptodotcom/cryptodotcom_convert.go	`57.89% <57.89%> (ø)`
exchanges/cryptodotcom/cryptodotcom_types.go	`82.85% <82.85%> (ø)`
...s/cryptodotcom/cryptodotcom_websocket_endpoints.go	`0.00% <0.00%> (ø)`
exchanges/cryptodotcom/cryptodotcom_websocket.go	`47.57% <47.57%> (ø)`
exchanges/cryptodotcom/cryptodotcom.go	`26.82% <26.82%> (ø)`
... and 1 more

... and 12 files with indirect coverage changes

shazbert

Thanks for changing the requested will go over authenticated endpoints once websocket is up and running.

exchanges/cryptodotcom/cryptodotcom_test.go

exchanges/cryptodotcom/cryptodotcom_websocket.go

exchanges/cryptodotcom/cryptodotcom_wrapper.go

exchanges/cryptodotcom/cryptodotcom_types.go

shazbert · 2023-02-08T02:40:44Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+var responseStream chan SubscriptionRawData
+
+// WsConnect creates a new websocket to public and private endpoints.
+func (cr *Cryptodotcom) WsConnect() error {


Websocket isn't working.

shazbert

Just some pending things on recent changes before I do function testing.

exchanges/cryptodotcom/cryptodotcom_test.go

exchanges/cryptodotcom/cryptodotcom_types.go

exchanges/cryptodotcom/cryptodotcom_wrapper.go

gloriousCode

This looks pretty good! I'm in the process of getting API access, so just a quick overall code quality check first

gloriousCode · 2023-02-19T23:46:25Z

testdata/configtest.json

@@ -1,5 +1,6 @@
 {


You should only be adding the new exchange here, not the other changes you've made

gloriousCode · 2023-02-20T01:40:27Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+var responseStream chan SubscriptionRawData
+
+// WsConnect creates a new websocket to public and private endpoints.
+func (cr *Cryptodotcom) WsConnect() error {


As I have highlighted in other reviews, just running the application with the exchange enabled is an excellent way of highlighting issues within your implementation and definitely should be part of how you test a given exchange PR.

[ERROR] | WEBSOCKET | 20/02/2023 10:49:42 | exchange Cryptodotcom websocket error - can not pass push data message with signature 106116263 with method subscribe

exchanges/cryptodotcom/cryptodotcom_wrapper.go

gloriousCode · 2023-02-20T02:02:37Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+
+// GenerateDefaultSubscriptions Adds default subscriptions to websocket to be handled by ManageSubscriptions()
+func (cr *Cryptodotcom) GenerateDefaultSubscriptions() ([]stream.ChannelSubscription, error) {
+	subscriptions := []stream.ChannelSubscription{}


Suggested change

subscriptions := []stream.ChannelSubscription{}

var subscriptions []stream.ChannelSubscription

The reason is because if there are any errors, we're not allocating memory space. Just declaring it as a var is an empty declaration. Its minor, but its a good practice to continue doing in all PRs

exchanges/cryptodotcom/cryptodotcom_wrapper.go

gloriousCode · 2023-02-20T02:05:30Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+
+// GetFeeByType returns an estimate of fee based on the type of transaction
+func (cr *Cryptodotcom) GetFeeByType(ctx context.Context, feeBuilder *exchange.FeeBuilder) (float64, error) {
+	return 0, common.ErrNotYetImplemented


Please implement

exchanges/cryptodotcom/cryptodotcom_websocket_eps.go

gloriousCode · 2023-02-20T02:16:01Z

exchanges/cryptodotcom/cryptodotcom.go

+		params.Set("depth", strconv.FormatInt(depth, 10))
+	}
+	var resp *OrderbookDetail
+	return resp, cr.SendHTTPRequest(ctx, exchange.RestSpot, common.EncodeURLValues(publicOrderbook, params), request.Unset, &resp)


You are not setting the ratelimits. I understand that this exchange has different style of ratelimits, but it seems you have defined them all but don't use them

exchanges/cryptodotcom/cryptodotcom_websocket.go

shazbert

Thanks for making the changes, this has a data race in websocket.

shazbert · 2023-02-28T05:57:28Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

-		return nil, fmt.Errorf("asset type of %s is not supported by %s", assetType, cr.Name)
+		return nil, fmt.Errorf("%w asset type: %v", asset.ErrNotSupported, assetType)
+	}
+	p, err := cr.FormatExchangeCurrency(p, asset.Spot)


asset.Spot -> assetType

No, since crypto.com only use Spot, there maybe some places where I used the terms interchangeably. But, I will fix that

shazbert

There are a lot of error messages that can be seen when running the application:

[ERROR] | WEBSOCKET | 17/03/2023 15:00:06 | exchange Cryptodotcom websocket error - could not match incoming message with signature: 146884893, and data: {"id":146884893,"code":0,"method":"subscribe","channel":"book.RSR_USDT"}

exchanges/cryptodotcom/cryptodotcom_wrapper.go

gloriousCode · 2023-03-19T23:21:49Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+	// instrumentOrderbookCnl,
+	// tickerCnl,


gloriousCode · 2023-03-19T23:24:37Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+	if err != nil {
+		return err
+	}
+	tickersDatas := make([]ticker.Price, len(data))


This doesn't do anything because websocketroutine_manager.go has no way of handling []ticker.Price so the data goes nowhere, forcing a REST switchover.

You'll need to update websocketroutine_manager.go to support it in the function websocketDataHandler

shazbert

Thanks some issues I have found. I will be opening up a PR to circumvent an edge case with respect to the GetHistoricCandles function shortly.

shazbert · 2023-03-27T04:13:03Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+}
+
+// ValidateCredentials validates current credentials used for wrapper
+func (cr *Cryptodotcom) ValidateCredentials(ctx context.Context, assetType asset.Item) error {


Not being used

shazbert · 2023-03-27T04:29:54Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+					kline.TwoWeek,
+					kline.OneMonth,
+				),
+				ResultLimit: 200,


shazbert · 2023-03-27T05:14:12Z

exchanges/cryptodotcom/cryptodotcom_websocket.go

+		if err != nil {
+			return err
+		}
+		time.Sleep(time.Second)


You pause everything up >= 20 seconds. Rate limiting is done within SendJSONMesage function. This was hard to find, running the application would have shown there was an issue.

I added that because it is advised to have a 1s interval and was not sure of the presence of a Rate limiter before sending the next JSON message.
I run the application but I didn't see an issue related to that. But, for now, I removed it

samuael · 2023-03-28T21:23:17Z

Thanks for your PR. And, I was also wondering whether to have such a variable to distinguish whether asset Items( instruments of asset items) have candlestick data necessarily. Since some instruments may not have candlestick data even with in an extended time range

…hrasher-corp#2013) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-version: 1.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…-corp#2017) Bumps [github.com/grpc-ecosystem/grpc-gateway/v2](https://github.com/grpc-ecosystem/grpc-gateway) from 2.27.1 to 2.27.2. - [Release notes](https://github.com/grpc-ecosystem/grpc-gateway/releases) - [Changelog](https://github.com/grpc-ecosystem/grpc-gateway/blob/main/.goreleaser.yml) - [Commits](grpc-ecosystem/grpc-gateway@v2.27.1...v2.27.2) --- updated-dependencies: - dependency-name: github.com/grpc-ecosystem/grpc-gateway/v2 dependency-version: 2.27.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…thrasher-corp#2015) Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.30 to 1.14.32. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.30...v1.14.32) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-version: 1.14.32 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…hrasher-corp#2014) Bumps google.golang.org/protobuf from 1.36.7 to 1.36.8. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-version: 1.36.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ps (thrasher-corp#1968) * set limiter to first level mock data list and updated unit tests * address nested slices length limit * minor fix recording file and update unit tests * minor updates on unit tests * re-record mock files and minor fix on the unit tests ti adapt the mock data change * improve http recording limit value and fix issues with mock data in binance * added MockDataSliceLimit in request items and resolve minor unit test issues * resolve missed conflict * rename mock variables, resolve unit test issues, and other updates * minor fix to CheckJSON and update unit tests * minor unit test fix * further optimization on mock CheckJSON method, unit tests, and re-record poloniex * common and recording unit tests fix * minor linter issues fix * unit tests format fix * fix miscellaneous error * unit tests fix and minor docs update * re-record and reduce mock file size * indentation fix * minor assertion test fix * reverted log.Printf line in live testing * rename variables * update NewVCRServer unit test * replace string comparison with *net.OpError check * restructur net error test * exchanges/mock: Remove redundant error assertion message in TestNewVCRServer --------- Co-authored-by: Adrian Gallagher <[email protected]>

…anges (thrasher-corp#1860) * move limits, transition to key gen * rollout NewExchangePairAssetKey everywhere * test improvements * self-review fixes * ok, lets go * fix merge issue * slower value func,assertify,drop IsValidPairString * remove binance reference for backtesting test * Redundant nil checks removed due to redundancy * Update order_test.go * Move limits back into /exchanges/ * puts limits in a different box again * SHAZBERT SPECIAL SUGGESTIONS * Update gateio_wrapper.go * fixes all build issues * Many niteroos! * something has gone awry * bugfix * gk's everywhere nits * lint * extra lint * re-remove IsValidPairString * lint fix * standardise test * revert some bads * dupe rm * another revert 360 mcgee * un-in-revertify * Update exchange/order/limits/levels_test.go Co-authored-by: Adrian Gallagher <[email protected]> * fix * Update exchanges/binance/binance_test.go HERE'S HOPING GITHUB FORMATS THIS CORRECTLY! Co-authored-by: Gareth Kirwan <[email protected]> * update text * rn func, same line err gk4202000 --------- Co-authored-by: Adrian Gallagher <[email protected]> Co-authored-by: Gareth Kirwan <[email protected]>

* linters: Add modernise tool check and fix issues * engine: Simplify exch.SetDefaults call and remove localWG * CI: Revert config versions lint workflow

…p#2020) * devcontainer: Update Dockerfile and configuration for GoCryptoTrader setup * devcontainer: Update comment for clarity on format and config details * devcontainer: Refactor post-create command to use dedicated script for tool installation * devcontainer: Update comment for Go modernise tool for clarity

Co-authored-by: mathieu cesbron <[email protected]>

… into cryptoCom

thrasher- · 2025-09-10T07:55:47Z

@codex please review

chatgpt-codex-connector

Codex Review: Here are some suggestions.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

chatgpt-codex-connector · 2025-09-10T07:57:59Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+func (e *Exchange) UpdateTradablePairs(ctx context.Context, forceUpdate bool) error {
+	assetTypes := e.GetAssetTypes(true)
+	for _, assetType := range assetTypes {
+		pairs, err := e.FetchTradablePairs(ctx, assetType)
+		if err != nil {
+			return err
+		}
+		if assetType == asset.OTC && !e.IsRESTAuthenticationSupported() {
+			continue
+		}
+		return e.UpdatePairs(pairs, assetType, false, forceUpdate)


[P1] Update tradable pairs for all assets

The loop in UpdateTradablePairs returns on the first iteration, so only the first asset type retrieved from GetAssetTypes(true) ever has its pairs updated. Subsequent asset types (e.g. PerpetualSwap) are skipped entirely, leaving their pairs stale and preventing features that rely on those assets from working. The function should continue iterating and only return after all assets are processed.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2025-09-10T07:57:59Z

exchanges/cryptodotcom/cryptodotcom.go

+func (e *Exchange) GetDepositHistory(ctx context.Context, ccy currency.Code, startTimestamp, endTimestamp time.Time, pageSize, page, status int64) (*DepositResponse, error) {
+	params := make(map[string]any)
+	if ccy.IsEmpty() {
+		params["currency"] = ccy.String()


[P2] Currency filter inverted in deposit history request

GetDepositHistory only attaches the currency parameter when ccy.IsEmpty() is true. This means a caller requesting a specific currency never includes that currency in the API request, while an empty currency sends an empty string. As a result, filtered deposit history cannot be retrieved. The condition should be if !ccy.IsEmpty() before setting the parameter.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2025-09-10T07:57:59Z

exchanges/cryptodotcom/cryptodotcom.go

+	params := make(map[string]any)
+	if !currencyPair.Base.IsEmpty() {
+		params["base_currency"] = currencyPair.Base.String()
+	}
+	if !currencyPair.Base.IsEmpty() {
+		params["quote_currency"] = currencyPair.Quote.String()


[P2] Quote currency omitted when only quote provided

In GetOTCTradeHistory, the code checks !currencyPair.Base.IsEmpty() for both the base and quote currency parameters. If the caller supplies only a quote currency, the quote parameter is never sent, causing the request to ignore the intended filter. The second condition should reference currencyPair.Quote instead of the base again.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2025-09-10T07:57:59Z

exchanges/cryptodotcom/cryptodotcom_wrapper.go

+	var fee float64
+	switch feeBuilder.FeeType {
+	case exchange.CryptocurrencyTradeFee:
+		fee = calculateTradingFee(feeBuilder) * feeBuilder.Amount * feeBuilder.PurchasePrice
+	case exchange.CryptocurrencyWithdrawalFee:


[P1] Trade fee multiplied twice

For CryptocurrencyTradeFee, calculateTradingFee already returns price * amount * rate, but the caller multiplies the result by feeBuilder.Amount * feeBuilder.PurchasePrice again. This squares the trade notional, drastically inflating reported fees. Assign the result directly instead of multiplying again to return the actual fee amount.

Useful? React with 👍 / 👎.

… into cryptoCom

shazbert requested a review from a team January 29, 2023 21:00

shazbert assigned samuael Jan 29, 2023

shazbert added the review me This pull request is ready for review label Jan 29, 2023

shazbert requested changes Jan 30, 2023

View reviewed changes

shazbert requested changes Feb 6, 2023

View reviewed changes

gloriousCode added reconstructing Based on PR feedback, this is currently being reworked and is not to be merged and removed review me This pull request is ready for review labels Feb 6, 2023

shazbert added review me This pull request is ready for review and removed reconstructing Based on PR feedback, this is currently being reworked and is not to be merged labels Feb 7, 2023

shazbert requested changes Feb 8, 2023

View reviewed changes

shazbert requested changes Feb 13, 2023

View reviewed changes

shazbert added reconstructing Based on PR feedback, this is currently being reworked and is not to be merged and removed review me This pull request is ready for review labels Feb 13, 2023

gloriousCode requested changes Feb 20, 2023

View reviewed changes

samuael force-pushed the cryptoCom branch from 5ccb8a0 to 48fa29d Compare February 20, 2023 16:40

gloriousCode added rebase/merge of master required and removed rebase/merge of master required labels Feb 26, 2023

samuael force-pushed the cryptoCom branch 2 times, most recently from d93f24a to a149dd9 Compare March 1, 2023 20:50

shazbert requested changes Mar 6, 2023

View reviewed changes

shazbert requested changes Mar 17, 2023

View reviewed changes

gloriousCode requested changes Mar 19, 2023

View reviewed changes

shazbert requested changes Mar 27, 2023

View reviewed changes

shazbert mentioned this pull request Mar 27, 2023

exchanges: add setTimeWindow boolean to GetKlineRequest param #1160

Merged

13 tasks

dependabot bot and others added 12 commits September 2, 2025 17:26

linters: Add modernise tool check and fix issues (thrasher-corp#2012)

2f5022f

* linters: Add modernise tool check and fix issues * engine: Simplify exch.SetDefaults call and remove localWG * CI: Revert config versions lint workflow

web: Fix typo in settings component (thrasher-corp#2022)

f480e93

Co-authored-by: mathieu cesbron <[email protected]>

added missing endpoints, and fix linter and other issues

42d8f33

updating trading endpoints based on recent changes

caf5c12

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

91285f5

… into cryptoCom

samuael force-pushed the cryptoCom branch from 469712a to 91285f5 Compare September 2, 2025 14:45

self review, minor fixes, and added announcement endpoint

833bbfc

chatgpt-codex-connector bot reviewed Sep 10, 2025

View reviewed changes

samuael added 14 commits September 16, 2025 22:23

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

a82c40e

… into cryptoCom

adding fiat wallet api endpoints

d5d1dba

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

606877f

… into cryptoCom

completed staking endpoints

d54cfa0

added a single comment

ada0316

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

79856b8

… into cryptoCom

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

5c2613f

… into cryptoCom

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

a8c660f

… into cryptoCom

fix errors caused after rebase

718c2bd

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

9f4b348

… into cryptoCom

code optimization and wrapper update

e82c8e7

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

c0dc2ae

… into cryptoCom

minor change

073f9b9

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

55a1c50

… into cryptoCom

	subscriptions := []stream.ChannelSubscription{}
	var subscriptions []stream.ChannelSubscription

exchanges: Add V2 Crypto.com exchange support #1122

Are you sure you want to change the base?

exchanges: Add V2 Crypto.com exchange support #1122

Uh oh!

Conversation

samuael commented Jan 29, 2023

PR Description

Type of change

How has this been tested

Checklist

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gloriousCode left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shazbert left a comment

codecov bot commented Feb 7, 2023 •

edited

Loading