Skip to content

Commit 65184cf

Browse files
Remove Ropsten-related config from deployment job
As the Ropsten testnet becomes deprecated in the near future, we are switching to deployment on Goerli. If deployment on Ropsten will be needed in the interm period, we will do it manually, not via GH Actions.
1 parent 439981e commit 65184cf

File tree

1 file changed

+5
-21
lines changed

1 file changed

+5
-21
lines changed

.github/workflows/contracts.yaml

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ jobs:
9999

100100
contracts-deployment-testnet:
101101
needs: [contracts-build-and-test]
102-
if: github.event_name == 'workflow_dispatch'
102+
if: github.event_name == 'workflow_dispatch' && github.event.inputs.environment == 'goerli'
103103
runs-on: ubuntu-latest
104104
steps:
105105
- uses: actions/checkout@v2
@@ -113,32 +113,15 @@ jobs:
113113
- name: Install dependencies
114114
run: yarn install --frozen-lockfile
115115

116-
# Ultimately, we want to get rid of steps deploying on Ropsten (as it will
117-
# be shut down in Q4 2022) and switch to deployment on Goerli. We're
118-
# leaving both deployment options for the transition period.
119-
- name: Resolve latest contracts on Ropsten
120-
if: github.event.inputs.environment == 'ropsten'
121-
run: yarn upgrade @keep-network/[email protected]
122-
123-
- name: Resolve latest contracts on Goerli
124-
if: github.event.inputs.environment == 'goerli'
116+
- name: Resolve latest contracts
125117
run: yarn upgrade @keep-network/[email protected]
126118

127119
- name: Configure tenderly
128120
env:
129121
TENDERLY_TOKEN: ${{ secrets.TENDERLY_TOKEN }}
130122
run: ./config_tenderly.sh
131123

132-
- name: Deploy contracts on Ropsten
133-
if: github.event.inputs.environment == 'ropsten'
134-
env:
135-
CHAIN_API_URL: ${{ secrets.ROPSTEN_ETH_HOSTNAME_HTTP }}
136-
CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.ROPSTEN_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
137-
KEEP_CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.ROPSTEN_KEEP_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
138-
run: yarn deploy --network ${{ github.event.inputs.environment }}
139-
140-
- name: Deploy contracts on Goerli
141-
if: github.event.inputs.environment == 'goerli'
124+
- name: Deploy contracts
142125
env:
143126
CHAIN_API_URL: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }}
144127
CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.GOERLI_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
@@ -163,6 +146,7 @@ jobs:
163146
- name: Notify CI about completion of the workflow
164147
# uses: keep-network/ci/actions/notify-workflow-completed@v1
165148
uses: keep-network/ci/actions/notify-workflow-completed@ci-goerli
149+
continue-on-error: true # TODO: remove before merge to main
166150
env:
167151
GITHUB_TOKEN: ${{ secrets.CI_GITHUB_TOKEN }}
168152
with:
@@ -211,7 +195,7 @@ jobs:
211195
- name: Verify contracts on Etherscan
212196
env:
213197
ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
214-
CHAIN_API_URL: ${{ secrets.ROPSTEN_ETH_HOSTNAME_HTTP }}
198+
CHAIN_API_URL: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }}
215199
run: |
216200
yarn run hardhat --network ${{ github.event.inputs.environment }} \
217201
etherscan-verify --license GPL-3.0 --force-license

0 commit comments

Comments
 (0)