-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below.
- checking tests ...
ERROR Running the tests in ‘tests/testthat.R’ failed. Last 13 lines of output: > > test_check("survutils") [31m──[39m [31m1. Failure: get_cox_res runs univariate Cox regression on a single feature (@[39m as.data.frame(out_df) not equal to as.data.frame(expected_out_df). Names: 1 string mismatch Length mismatch: comparison on first 6 components Component 6: Modes: character, numeric Component 6: target is character, current is numeric ══ testthat results ═══════════════════════════════════════════════════════════ [ OK: 6 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ] 1. Failure: get_cox_res runs univariate Cox regression on a single feature (@test_get_cox_res.R#48) Error: testthat unit tests failed Execution halted
I believe this test failure is caused by the following change:
All
conf.intarguments now default toFALSE, and allconf.levelarguments now default to0.95.
We made this change as confidence interval calculations for many model objects are computationally intensive.
If so, just set conf.int = TRUE in your calls to tidy.*() methods and you should be good to go!🙂
We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!
Metadata
Metadata
Assignees
Labels
No labels