Use deepcopy when copying Piccolo queries (#1677)

Author: uriyyo

fastapi_pagination/ext/piccolo.py

@@ -1,7 +1,7 @@
 __all__ = ["apaginate", "paginate"]
 
 from contextlib import suppress
-from copy import copy
+from copy import deepcopy
 from functools import partial
 from typing import Any, TypeVar, cast
 
@@ -28,7 +28,7 @@ def _copy_query(query: Select[TTable_co]) -> Select[TTable_co]:
 
     for s in select_cls.__slots__:
         with suppress(AttributeError):
-            setattr(q, s, copy(getattr(query, s)))
+            setattr(q, s, deepcopy(getattr(query, s)))
 
     return q
 

tests/ext/test_piccolo.py

@@ -10,7 +10,7 @@
 from piccolo.table import Table
 from pytest_asyncio import fixture as async_fixture
 
-from fastapi_pagination.ext.piccolo import paginate
+from fastapi_pagination.ext.piccolo import apaginate
 from tests.base import BasePaginationTestSuite
 from tests.utils import faker
 
@@ -33,7 +33,7 @@ def query(request):
     if request.param:
         return User
 
-    return User.select()
+    return User.select().order_by(User.id)
 
 
 DB = SQLiteEngine()
@@ -74,6 +74,6 @@ async def entities(self, query, client):
     def app(self, builder, query, engine):
         @builder.both.default
         async def route():
-            return await paginate(query)
+            return await apaginate(query)
 
         return builder.build()