https://github.com/veertuinc/anka-cloud-gitlab-executor/pull/36/files\#r2499592609 Pushing state removal

NorseGaud · NorseGaud · commit cd74174b7171 · 2025-11-06T10:48:48.000-06:00
diff --git a/internal/ankacloud/controller.go b/internal/ankacloud/controller.go
@@ -35,7 +35,6 @@ const (
 	StateTerminating InstanceState = "Terminating"
 	StateTerminated  InstanceState = "Terminated"
 	StateError       InstanceState = "Error"
-	StatePushing     InstanceState = "Pushing"
 )
 
 type VM struct {
@@ -231,14 +230,6 @@ func (c *controller) GetInstanceByExternalId(ctx context.Context, externalId str
 		}
 	}
 
-	// If no instances are in good states, return the first non-terminated/error instance
-	for _, instance := range matchingInstances {
-		switch instance.State {
-		case StatePushing:
-			return instance, nil
-		}
-	}
-
 	// As a last resort, return the first matching instance (could be Error/Terminated)
 	return matchingInstances[0], nil
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ const (`
`35`	`35`	`StateTerminating InstanceState = "Terminating"`
`36`	`36`	`StateTerminated InstanceState = "Terminated"`
`37`	`37`	`StateError InstanceState = "Error"`
`38`		`- StatePushing InstanceState = "Pushing"`
`39`	`38`	`)`
`40`	`39`
`41`	`40`	`type VM struct {`
`@@ -231,14 +230,6 @@ func (c *controller) GetInstanceByExternalId(ctx context.Context, externalId str`
`231`	`230`	`}`
`232`	`231`	`}`
`233`	`232`
`234`		`- // If no instances are in good states, return the first non-terminated/error instance`
`235`		`- for _, instance := range matchingInstances {`
`236`		`- switch instance.State {`
`237`		`- case StatePushing:`
`238`		`- return instance, nil`
`239`		`- }`
`240`		`- }`
`241`		`-`
`242`	`233`	`// As a last resort, return the first matching instance (could be Error/Terminated)`
`243`	`234`	`return matchingInstances[0], nil`
`244`	`235`	`}`